Skip to content

feature/biocViews accessibility #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LiNk-NY wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

feature/biocViews accessibility #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64ee5ff
add accessibility navigation in browse mode
LiNk-NY Aug 4, 2026
8d2d8f5
remove tabindex for non-interactive static text table
LiNk-NY Aug 5, 2026
621e56b
remove auto added role="grid" attribute
LiNk-NY Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 46 additions & 13 deletions assets/js/bioc_views.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ var displayPackages = function (packageList, nodeName) {
};

html +=
"<table role='table' id='biocViews_package_table' aria-label='Packages table' tabindex='0'>\n" +
"<table role='table' id='biocViews_package_table' aria-label='Packages table'>\n" +
"<thead><tr role='row'>" +
"<th role='columnheader' scope='col'>Package</th>" +
"<th role='columnheader' scope='col'>Maintainer</th>" +
"<th role='columnheader' scope='col'>Title</th>" +
"<th role='columnheader' scope='col'>Rank</th>" +
"<th role='columnheader' scope='col'><button type='button' class='sort-btn' aria-label='Sort Package column'>Package</button></th>" +
"<th role='columnheader' scope='col'><button type='button' class='sort-btn' aria-label='Sort Maintainer column'>Maintainer</button></th>" +
"<th role='columnheader' scope='col'><button type='button' class='sort-btn' aria-label='Sort Title column'>Title</button></th>" +
"<th role='columnheader' scope='col'><button type='button' class='sort-btn' aria-label='Sort Rank column'>Rank</button></th>" +
"</tr></thead><tbody>\n";

var tableData = "";
Expand All @@ -51,14 +51,14 @@ var displayPackages = function (packageList, nodeName) {
var url = getHostUrl() + "/" + map[category] + "/html/" + pkg + ".html";
//tableData += '<tr class="'+rowClass+'" id="pkg_' + pkg + '">\n';
tableData += '<tr role="row" id="pkg_' + pkg + '">\n';
tableData += '\t<td role="cell" tabindex="0"><a href="' + url + '" aria-label="' + pkg + '">' + pkg + "</a></td>\n";
tableData += '\t<td role="cell"><a href="' + url + '" aria-label="' + pkg + '">' + pkg + "</a></td>\n";
var cleanMaintainer = packageInfo[pkg]["Maintainer"].replace(
/ *<[^>]*>/g,
""
);
tableData += '\t<td role="cell" tabindex="0">' + cleanMaintainer + "</td>\n";
tableData += '\t<td role="cell" tabindex="0">' + packageInfo[pkg]["Title"] + "</td>\n";
tableData += '\t<td role="cell" tabindex="0">' + packageInfo[pkg]["Rank"] + "</td>\n";
tableData += '\t<td role="cell">' + cleanMaintainer + "</td>\n";
tableData += '\t<td role="cell">' + packageInfo[pkg]["Title"] + "</td>\n";
tableData += '\t<td role="cell">' + packageInfo[pkg]["Rank"] + "</td>\n";
tableData += "</tr>\n";
}
html += tableData;
Expand All @@ -80,17 +80,50 @@ var displayPackages = function (packageList, nodeName) {
};
jQuery("#packages").html(html);
jQuery("#biocViews_package_table").dataTable({
sScrollX: "100%",
aLengthMenu: [
[-1, 10, 25, 50, 100],
["All", 10, 25, 50, 100],
[50, 100, 250, -1],
[50, 100, 250, "All"],
],
iDisplayLength: -1,
iDisplayLength: 50,
aoColumns: [null, null, null, { sType: "numWithNull" }],
aaSorting: [[3, "asc"]],
oLanguage: {
sSearch: "Search table:",
},
fnInitComplete: function () {
// DataTables automatically stamps role="grid" onto the wrapper div
// it generates. That conflicts with the role="table"/"row"/
// "columnheader" semantics already set on the markup above, and
// makes screen readers like Orca treat this as an interactive grid
// widget (expecting arrow-key grid navigation) instead of a normal,
// browsable table. Remove it so native table navigation works.
jQuery("#biocViews_package_table")
.closest(".dataTables_wrapper")
.removeAttr("role");
},
fnDrawCallback: function () {
var table = jQuery("#biocViews_package_table");
table
.closest(".dataTables_wrapper")
.removeAttr("role");
table.find("tbody")
.removeAttr("role")
.removeAttr("aria-live")
.removeAttr("aria-relevant");

table.find("th").each(function () {
var th = jQuery(this);
th.removeAttr("tabindex").removeAttr("aria-label");

if (th.hasClass("sorting_asc")) {
th.attr("aria-sort", "ascending");
} else if (th.hasClass("sorting_desc")) {
th.attr("aria-sort", "descending");
} else if (th.hasClass("sorting")) {
th.attr("aria-sort", "none");
}
});
},
});
};

Expand Down
3 changes: 2 additions & 1 deletion assets/style/components/tables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ table.full-width {
width: 100%;
}

#biocViews_package_table thead th,
.dataTables_scrollHead {
background: var(--neutral-n75);
padding-top: 10px;
padding: 0.75rem 0.5rem;
}

tr:first-of-type *:first-child {
Expand Down
12 changes: 12 additions & 0 deletions assets/style/pages/packages.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,18 @@ summary.package-details {
border-radius: 0.5rem;
}

#biocViews_package_table th button.sort-btn {
background: none;
border: none;
color: inherit;
font: inherit;
padding: 0;
margin: 0;
cursor: pointer;
text-align: inherit;
width: 100%;
}

.packages-subnav {
background: linear-gradient(white, white) padding-box,
var(--gradient-brand) border-box;
Expand Down