feat(sdk-coin-flrp): add createPairedWallet method to Flrp#8578
Open
ashutoshkumar-6 wants to merge 1 commit intomasterfrom
Open
feat(sdk-coin-flrp): add createPairedWallet method to Flrp#8578ashutoshkumar-6 wants to merge 1 commit intomasterfrom
ashutoshkumar-6 wants to merge 1 commit intomasterfrom
Conversation
ashutoshkumar-6
force-pushed
the
feat/SI-287-flrp-create-paired-wallet
branch
from
a2b3306 to
99c3424
Compare
ashutoshkumar-6
added a commit
that referenced
this pull request
Apr 20, 2026
Add CreatePairedWalletParams and CreatePairedWalletResponse interfaces to iface.ts. Add createPairedWallet() method to the Flrp class that POSTs to /api/v2/flrp/wallet/:walletId/create-paired-wallet. Add unit tests covering label/no-label and error cases. Closes #8578
ashutoshkumar-6
force-pushed
the
feat/SI-287-flrp-create-paired-wallet
branch
from
99c3424 to
1bafc61
Compare
ashutoshkumar-6
added a commit
that referenced
this pull request
Apr 20, 2026
Add CreatePairedWalletParams and CreatePairedWalletResponse interfaces to iface.ts. Add createPairedWallet() method to the Flrp class that POSTs to /api/v2/flrp/wallet/:walletId/create-paired-wallet. Add unit tests covering label/no-label and error cases. Closes #8578
ashutoshkumar-6
force-pushed
the
feat/SI-287-flrp-create-paired-wallet
branch
from
1bafc61 to
aecf9e8
Compare
Add CreatePairedWalletParams and CreatePairedWalletResponse interfaces to iface.ts. Add createPairedWallet() method to the Flrp class that POSTs to /api/v2/flrp/wallet/:walletId/create-paired-wallet. Add unit tests covering label/no-label and error cases. Closes #8578
ashutoshkumar-6
force-pushed
the
feat/SI-287-flrp-create-paired-wallet
branch
from
16af4d0 to
2f31fb4
Compare
joshisakshi
approved these changes
Apr 21, 2026
Doddanna17
approved these changes
Apr 21, 2026
Contributor
Doddanna17
left a comment
Doddanna17
left a comment
There was a problem hiding this comment.
Implementation is correct — URL pattern, conditional body, and .result() chaining all follow existing conventions.
Two minor items:
CreatePairedWalletResponse: top-level[key: string]: unknownis unnecessary since all fields are typed; remove it to preserve type safety for callers.coinSpecificindex sig is fine.- PR description claims "Add nock devDependency" but
package.jsonis not in the diff. Nock resolves from root workspace so CI will pass, but the module'spackage.jsonshould declare it explicitly if that was the intent.
LGTM otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SI-287
Summary
CreatePairedWalletParamsandCreatePairedWalletResponseinterfaces tosrc/lib/iface.tscreatePairedWallet(params)method to theFlrpclass insrc/flrp.tsthat POSTs to/api/v2/flrp/wallet/:walletId/create-paired-walletnockdevDependency and 3 unit tests covering label, no-label, and HTTP error casesTest plan
yarn unit-test --scope @bitgo/sdk-coin-flrppassescreatePairedWalletwith label POSTs{ label }bodycreatePairedWalletwithout label POSTs empty body🤖 Generated with Claude Code