fix(esm): append .js extensions to relative and subpath imports#8594
Open
harshitanand wants to merge 1 commit intoBitGo:masterfrom
Open
fix(esm): append .js extensions to relative and subpath imports#8594harshitanand wants to merge 1 commit intoBitGo:masterfrom
harshitanand wants to merge 1 commit intoBitGo:masterfrom
Conversation
kaustubhbitgo
requested changes
Apr 22, 2026
Contributor
kaustubhbitgo
left a comment
There was a problem hiding this comment.
From the original issue I would suggest to either use tsc-alias or bundler option as they cover multiple edge cases when it comes to resolve imports / other issues in esm.
Author
|
Thanks for the review! Understood — the custom post-processor is brittle compared to Could you clarify which approach you'd prefer me to implement?
Happy to implement either. |
Contributor
|
flushing, please reping when the fix is ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added a post-processor script to append
.jsextensions to ESM builds for@bitgo/abstract-utxoand@bitgo/utxo-coreto fix module resolution errors.How
Created a lightweight Node.js script
scripts/fix-esm.jsthat findsimport/exportstatements in the emitteddist/esmfiles and intelligently adds.jsextensions to relative paths and specificbip174subpaths without breaking existing CJS builds.Testing
yarn build:esm— CLEANyarn test— 1942 passed, 0 failedRelated
Closes #7660