feat(sdk-core): add webauthnInfo support to createMpc#8607
Open
mohammadalfaiyazbitgo wants to merge 3 commits intomasterfrom
Open
feat(sdk-core): add webauthnInfo support to createMpc#8607mohammadalfaiyazbitgo wants to merge 3 commits intomasterfrom
mohammadalfaiyazbitgo wants to merge 3 commits intomasterfrom
Conversation
Add MpcWebauthnInfo parameter to CreateMpcOptions and thread it through
all four createKeychains implementations (EDDSA, EdDSA MPCv2, ECDSA,
ECDSA MPCv2). When provided, the user keychain is registered with an
additional webauthnDevices entry containing a PRF-encrypted copy of the
user private share, avoiding the need for a separate PUT /key/{id} call
post-wallet-creation.
Also wires webauthnInfo from generateWallet through generateMpcWallet
so TSS wallet creation passes the authenticator info end-to-end.
Ticket: WAL-761
The recipientKeychainParams object in createParticipantKeychain used a prv field not present in AddKeychainOptions. Remove the explicit type annotation so TypeScript infers the broader object literal type, and inline the webauthnDevices conditional to keep the declaration atomic. Ticket: WAL-761
MpcWebauthnInfo and GenerateWalletWebauthnInfo were identical shapes. Promote GenerateWalletWebauthnInfo to iKeychains.ts as the single canonical type, re-export it from iWallets.ts, and drop the duplicate definition. All createKeychains implementations and CreateMpcOptions now reference the shared type. The onchain hot wallet path in generateWallet already wires webauthnInfo through userKeychainPromise; no additional changes are needed there. Ticket: WAL-761
mohammadalfaiyazbitgo
force-pushed
the
wal-761-webauthn-info-create-mpc
branch
from
e9c8790 to
0636e4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
** Summary
MpcWebauthnInfointerface ({ otpDeviceId, prfSalt, passphrase }) iniKeychains.tsfor passing a PRF-derived passphrase into MPC key creationwebauthnInfo?: MpcWebauthnInfotoCreateMpcOptionsand threads it through all fourcreateKeychainsimplementations (EDDSA, EdDSA MPCv2, ECDSA, ECDSA MPCv2)webauthnDevicesentry on the user keychain encrypted with the PRF-derived passphrasewebauthnInfofromGenerateWalletOptionsthroughgenerateMpcWallet→createMpcfor the TSS wallet creation pathwebauthnInfois correctly forwarded to the underlyingcreateKeychainsfor both EDDSA and ECDSA TSSTest plan
yarn run unit-test --scope bitgoand verify new "should pass webauthnInfo to createKeychains" tests passcreateParticipantKeychaintests in ecdsaMPCv2 and ecdsa still passCloses WAL-761
🤖 Generated with Claude Code