feat(sdk-core): WCN-187 add passkey types, webauthn provider interface, and prf helpers#8610
Open
feat(sdk-core): WCN-187 add passkey types, webauthn provider interface, and prf helpers#8610
Conversation
derranW26
requested review from
alextse-bg,
kaustubhbitgo and
mohammadalfaiyazbitgo
derranW26
force-pushed
the
WCN-187-passkey-types
branch
4 times, most recently
from
7623c7d to
b89ec3a
Compare
…rf helpers - WebAuthnOtpDevice: registration-flow type with credID, fmt, publicKey, prfSalt?, encryptedPrv? - PasskeyAuthResult: mirrors retail ChallengeFor2FAWithPrfResult exactly - WebAuthnProvider: browser abstraction returning PublicKeyCredential | null - buildEvalByCredential: takes KeychainWebauthnDevice[], reads authenticatorInfo.credID - matchDeviceByCredentialId: takes KeychainWebauthnDevice[], throws with known IDs on miss - export * from './passkey' added to bitgo/index.ts barrel - unit tests: 7 cases covering happy path, empty list, and descriptive error content TICKET: WCN-187
derranW26
force-pushed
the
WCN-187-passkey-types
branch
from
b89ec3a to
29526ab
Compare
alextse-bg
reviewed
Apr 24, 2026
Contributor
alextse-bg
left a comment
alextse-bg
left a comment
There was a problem hiding this comment.
code changes lgtm, not sure I have enough context to review the type changes tho
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PasskeyDevice,PasskeyAuthResult, andWebAuthnProvidertypes tomodules/sdk-core/src/bitgo/passkey/types.tsbuildEvalByCredential— mapscredId → prfSaltfor WebAuthn PRFevalByCredentialobjectmatchDeviceByCredentialId— resolves a WebAuthn assertion's credential ID back to itsPasskeyDevice, throws descriptively if not foundDepends on
@bitgo/passkey-crypto) must be merged first — downstream tickets (3–7) will use these types alongsidederivePassword/deriveEnterpriseSaltfrom that packageNotes
WebAuthnProvidertargets browser only (PublicKeyCredentialtypes) — no Node.js or React Nativeanytypes