Conversation
- Bump @bitgo/wasm-mps to 1.7.0 which exposes chaincode on the Share struct - Add shareChaincode field and getCommonKeychain() to DKG class in sdk-lib-mpc, returning pubkey+chaincode (128 hex chars) matching Eddsa.deriveUnhardened expectations - Use getCommonKeychain() in EddsaMPCv2Utils.createKeychains and pass full keychain to user/backup/bitgo keychains instead of just the 32-byte public key - Rename commonPublicKey to commonPublicKeychain in round 2 response handling to align with updated @bitgo/public-types and HSM response field name - Remove 64-char MPCv2 special case from getPublicKeyFromCommonKeychain; all EdDSA keychains are now uniformly 128 hex chars (pubkey + chaincode) - Update tests accordingly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> TICKET: WCI-230
Marzooqa
requested review from
mohammadalfaiyazbitgo,
ranga-r2 and
zahin-mohammad
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
TICKET: WCI-230