Skip to content

Refactor transaction-explorer: fix zero-value handling, simplify fee logic, and optimize address Set creation #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamespepper81 merged 6 commits into from
Jan 9, 2026
Merged

Refactor transaction-explorer: fix zero-value handling, simplify fee logic, and optimize address Set creation #440

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2bdcf4
Initial plan
Copilot Jan 9, 2026
ccd6b48
Apply code quality improvements to transaction-explorer.tsx
Copilot Jan 9, 2026
d7afeb5
Add missing Wallet import to fix TypeScript error
Copilot Jan 9, 2026
a0dc446
Fix memoization reference check to work correctly
Copilot Jan 9, 2026
8c4ea52
Fix null/undefined handling in memoization cache
Copilot Jan 9, 2026
44adfeb
Merge pull request #439 from BitSleuthAI/copilot/fix-inconsistent-par…
jamespepper81 Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions app/transaction-explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { GradientBackground } from '@/components/GradientBackground';
import { platformStyles } from '@/constants/themes';
import { useWallet } from '@/hooks/wallet-store';
import { getTransactionDetails } from '@/services/esplora-service';
import { Transaction } from '@/types/wallet';
import { Transaction, Wallet } from '@/types/wallet';
import * as Clipboard from 'expo-clipboard';
import { router, Stack, useLocalSearchParams } from 'expo-router';
import {
Expand Down Expand Up @@ -50,6 +50,19 @@ interface TransactionExplorerData {
}[];
}

// Memoize the Set of wallet addresses to avoid recreating it on every function call.
let lastAddressesRef: readonly string[] | undefined | null;
let lastAddressSet: Set<string> | undefined;

function getAddressSet(addresses: readonly string[] | undefined | null): Set<string> {
if (addresses === lastAddressesRef && lastAddressSet) {
return lastAddressSet;
}
lastAddressesRef = addresses;
lastAddressSet = new Set(addresses ?? []);
return lastAddressSet;
}

const SATOSHIS_PER_BTC = 1e8;

interface NormalizedVoutSource {
Expand Down Expand Up @@ -184,8 +197,6 @@ export default function TransactionExplorerScreen() {
}
};



if (loading) {
return (
<GradientBackground theme={theme} variant="primary" direction="vertical">
Expand Down Expand Up @@ -678,7 +689,7 @@ const styles = StyleSheet.create({
const buildExplorerData = (
txDetails: Transaction,
bitcoinPrice: { usd?: number } | null,
userWallet: Wallet | null,
currentWallet: Wallet | null,
): TransactionExplorerData => {
const statusInfo = txDetails.status || {};
const vinList = Array.isArray(txDetails.inputs) ? txDetails.inputs : txDetails.vin || [];
Expand All @@ -688,7 +699,7 @@ const buildExplorerData = (
// Some sources provide prevout directly, others provide value/address at the top level.
const normalizeVin = vinList.map((vin: NormalizedVinSource) => ({
prevout: vin.prevout || {
value: vin.value ? Math.round(vin.value * SATOSHIS_PER_BTC) : 0,
value: typeof vin.value === 'number' ? Math.round(vin.value * SATOSHIS_PER_BTC) : 0,
scriptpubkey_address: vin.address,
},
}));
Expand All @@ -699,10 +710,10 @@ const buildExplorerData = (

const inputValueSats = normalizeVin.reduce((sum, vin) => sum + (vin.prevout?.value ?? 0), 0);
const outputValueSats = normalizeVout.reduce((sum, vout) => sum + (vout.value ?? 0), 0);
const feeSats = typeof txDetails.fee === 'number' ? txDetails.fee : (txDetails.fee ?? 0);
const feeSats = txDetails.fee ?? 0;
const feeBtc = feeSats / SATOSHIS_PER_BTC;

const addressSet = new Set(userWallet?.addresses ?? []);
const addressSet = getAddressSet(currentWallet?.addresses);
const fallbackNetAmountSats = (() => {
if (typeof txDetails.amount === 'number') {
return Math.round(txDetails.amount * SATOSHIS_PER_BTC);
Expand Down