fix(models): mark MiniMax M3 vision-capable - #226
Open
octo-patch wants to merge 1 commit into
Open
Conversation
The target metadata lists text, image, and video input for MiniMax M3, but the model was registered without the vision flag. ClawRouter's image_url detection and filterByVision path therefore excluded M3 from the candidate pool whenever a request carried an image_url content part. Add vision: true so image requests reach the model. M2.7 stays text-only and is left unchanged.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: MiniMax M3 is registered without the vision flag, so ClawRouter's existing image_url detection and vision-filter path exclude it even though the target metadata supports text, image, and video input.
Changes
vision: trueto theminimax/minimax-m3entry insrc/models.tssosupportsVision()returns true andfilterByVision()keeps M3 in the candidate pool for requests that carryimage_urlcontent parts.src/models.test.tsasserting M3 is vision-capable and M2.7 (text-only upstream) is not.M2.7 is intentionally left without the flag; only M3 carries text+image+video input in the target metadata.
Checks
npx tsc --noEmitnpx vitest run src/models.test.tsnpx prettier --check src/models.ts src/models.test.tsnpx eslint src/models.ts src/models.test.tsSummary by CodeRabbit