ui: always selects the next-keyboard button when cycling to a new keyboard screen - #334
Open
epicleafies wants to merge 1 commit into
Open
ui: always selects the next-keyboard button when cycling to a new keyboard screen#334epicleafies wants to merge 1 commit into
epicleafies wants to merge 1 commit into
Conversation
…reen
The multi-page keyboard entry screens (passphrase, otp name) set no
initial selection, so the first time each page was shown the selection
fell back to the first character key ('A', '1', ':') - even though every
page after the first is only ever reached by clicking the previous
page's 'next keyboard' button, and every later visit to a page starts on
its 'next' button (which remains selected from when it was clicked to
move on).
Set the 'next keyboard' button as the initial selection for every page
after the first, so pages reached by clicking 'next' consistently start
on 'next'. The first page is shown without any 'next' click and keeps
its default initial selection (its first character key).
Collaborator
|
@bitcoinhelp Can you verify/ack the UI change proposed? PR itself looks fine. Another description on the corresponding issue here: #333 |
Contributor
|
@jgriffiths ack on the proposal itself, makes sense to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333.
The multi-page keyboard entry screens (passphrase, otp name) set no initial selection, so the first time each page was shown the selection fell back to the first character key ('A', '1', ':'). This happens even though every page after the first is only ever reached by clicking the previous page's 'next keyboard' button, and every later visit to a page starts on its 'next' button (which remains selected from when it was clicked to move on).
Sets the 'next keyboard' button as the initial selection for every page after the first. Pages reached by clicking 'next' consistently start on 'next'. The first page is shown without any 'next' click and keeps its default initial selection (its first character key).
Verified on a esp32-s3-devkitc-1 build (ESP-IDF v5.5.4) against current master (5ad8566).