serverpack creator re-work#408
Conversation
WIP, still needs images
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 56839624d0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| </Tabs> | ||
| ## Part 2. Installing on panel. | ||
|
|
||
| 1. To prepare for your serverpack, delete all the files currently inside the file manager in the duckpanel. This is to ensure there will be no confusion on where files are when you unarchive the serverpack. |
There was a problem hiding this comment.
Remove instruction to delete all panel files
Step 1 tells users to delete everything in the panel file manager before uploading a server pack, which can wipe existing worlds, configs, and other persistent data on non-fresh servers; this is an irreversible data-loss path introduced by this rewrite and it is not required for unpacking a generated server pack. The guidance should be scoped to a new/empty server or require a backup-first flow.
Useful? React with 👍 / 👎.
| <TabItem value="curseforge" label="Curseforge"> | ||
| Steps: | ||
|
|
||
| 1. Open SPC and navigate to your modpack folder. To find out the modpack folder, right-click the modpack in the launcher and click "Open Folder". Then read the folder location and navigate to it from SPC. CFImage1 (shows how to read the folder location) |
There was a problem hiding this comment.
Replace unresolved launcher image placeholders
The CurseForge, Modrinth, and Prism steps currently include raw placeholder tokens like CFImage1 instead of actual embedded images/links, so users cannot see the referenced folder-location examples that the instructions depend on. In this state, the guide’s launcher-specific navigation flow is incomplete and likely to cause users to pick the wrong directory.
Useful? React with 👍 / 👎.
|
Hey! This looks pretty good! The only thing to mention is that I think you forgot to add the detail of moving files "up" if they get unarchived into a subdirectory. |
|
Ah true, I will most likely add a common issues line. The way it works is that if you have the create zip archive enabled when making a serverpack itll not need to be moved up as itll unzip everything in the root dir. I needed to add a few more things on this either way so will be adding them soon* |
WIP, still needs images