wide/sca: Support upper bits + minor bug fixes#391
Draft
erichelgeson wants to merge 3 commits into
Draft
Conversation
Two bugs on the SCA: - With no images found, the RAW fallback resolved the strapped SCA ID into fallback_id for initDevice() but then opened the raw disk on the hard-coded RAW_FALLBACK_SCSI_ID, so the drive appeared on the wrong ID with another ID's settings. Open on the resolved fallback_id. - check_is_sca_model() latched is_sca_proto as soon as the write to the prototype I2C address succeeded, even when the following read failed and the probe returned false. Later flag reads would then address the prototype chip on a board that never answered as one. Latch only after the chip actually responds.
BlueSCSI Memory ReportCompared against release Memory Usage
Symbol Region ChangesPico_Audio_SPDIF: 1 symbols moved RAM → FLASH (-96 B RAM)
Pico_DaynaPORT: 1 symbols moved RAM → FLASH (-96 B RAM)
|
erichelgeson
commented
Jul 15, 2026
| status = i2c_write_timeout_us(I2C_PORT, SCA_I2C_ADDR_PROTO, cmd, 1, true, 25000); | ||
| if (status > 0) { | ||
| status = i2c_read_timeout_us(I2C_PORT, SCA_I2C_ADDR_PROTO, &response, 1, false, 25000); | ||
| is_sca_proto = true; |
Contributor
Author
There was a problem hiding this comment.
Via chat with @androda - we dont need to support sca proto types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft till test a few more machines, land on BlueSCSI Toolbox approach.