Skip to content

(NOT TO Land) No Case: SAC-DisCor.#17

Open
RuofanKong wants to merge 1 commit into
releases/0.6.6from
rukon/discor
Open

(NOT TO Land) No Case: SAC-DisCor.#17
RuofanKong wants to merge 1 commit into
releases/0.6.6from
rukon/discor

Conversation

@RuofanKong

Copy link
Copy Markdown

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/latest/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failure rates at https://ray-travis-tracker.herokuapp.com/.
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested (please justify below)

@Edilmo Edilmo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RuofanKong can we abandon this? or you want to keep it around?

@RuofanKong

Copy link
Copy Markdown
Author

@Edilmo Thanks for checking! This is prototyping SAC-Discor, an algorithm on top SAC as an option to improve convergence of SAC. I want to keep this PR for a while. Once we landed Apex-SAC, we may need to evaluate if there's a need to incorporate this new algorithm afterwards. I will definitely let you know.

@Edilmo

Edilmo commented Jul 31, 2020

Copy link
Copy Markdown

@Edilmo Thanks for checking! This is prototyping SAC-Discor, an algorithm on top SAC as an option to improve convergence of SAC. I want to keep this PR for a while. Once we landed Apex-SAC, we may need to evaluate if there's a need to incorporate this new algorithm afterwards. I will definitely let you know.

No problem. Thanks for the quick answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants