Bioc review#7
Merged
Merged
Conversation
Fixing vignette for installation cues and removing Seurat references. Also expanding executable chunks. Per issue: Bioconductor/Contributions#4143 (comment)
Adding parallel via BiocParallelParam per issue: Bioconductor/Contributions#4143 (comment)
Handling immApex install
Based on changes from Bioconductor/Contributions#4143
Per bioconductor review: Bioconductor/Contributions#4143
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Validation section to the README with concordance metrics
against the published GLIPH and GLIPH2 cluster vectors from
Glanville et al. (2017) and Huang et al. (2020). With paper-matched
parameters, immGLIPH reproduces the published cluster vectors at
ARI 0.985 (Glanville) and 0.863 (Huang) on the intersection of
shared CDR3s. Full benchmark code lives at
BorchLab/immGLIPH-benchmark.
Fixed
clusterScoring()failure in the clonal-expansion-enrichmenttest when a cluster contains more members than the reference pool
has rows. The null draw now uses
replace = TRUE(bootstrap),matching the V-gene null and the statistically appropriate choice
for resampling. Surfaced on the Huang 2020 benchmark.
Replaced
foreach/doParallelwithBiocParallelfor parallelizationacross all functions per Bioconductor recommendations.
Replaced
devtools::install_github()references withBiocManager::install()in vignette and error messages.Updated vignette to use
SingleCellExperimentinstead ofSeuratforthe single-cell workflow example.
Fixed
combineTCR()example in vignette (removed obsoletecellsargument).
Made more vignette code chunks evaluable (
clusterScoring(),deNovoTCRs(),plotNetwork()examples).Noted that
scRepertoireandimmApexare Bioconductor packages.Replaced iterative for-loop list growing with vectorized alternatives
(
lapply(),vapply(),Reduce()).Standardized code spacing around operators and after commas per
Bioconductor coding style.
All issues based on: immGLIPH Bioconductor/Contributions#4143