Repository navigation
fix(client): open native model settings through its named entry - #3241
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Review artifact status: an exact-head HTML explainer was generated for 8657b9e with five panels and zero writing warnings. It remains a local handoff, not a publicly accessible review artifact; browser rendering could not be verified because the browser bootstrap was unavailable. The GitHub before/after PNGs in the body both return HTTP 200 image/png. Runtime opening evidence, component tests, remaining close/return and native/Human QA are recorded separately in the body. No merge or release performed. |
Issue: #3222 Agent-Task: codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0
|
Head update: ee35bdf supersedes the prior explainer head. Initial CI failed in two external-entry tests whose synthetic Settings buttons lacked accessible names. Reproduced locally: 2 failed / 7 passed; adding the real Settings name to both fixtures makes the same command 9/9 green and the four-file navigation suite 29/29 green. No generic production fallback was added. The local HTML explainer is refreshed for this exact head with zero writing warnings; public HTML/browser access remains unavailable. Existing before/after images stay pinned to their capture-containing commit. New CI and the documented runtime/Human QA remain pending. |
Closes #3222 · delivery claim
Tasks:
codex/local/01a191d8-2941-78f0-b560-5a779e027f81(reproduction and fix),codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0(independent PR and verification docs).Why the change
Open model setup through the named native Settings entry instead of accidentally opening the mobile app dialog.
Special things to note
Change outline
First-run Models — isolated DSH rc.3 Web Client, Chinese, 1440 × 900
Before — the model setup action opened the mobile app dialog.
After — the same action opens native Settings, Models, with Add model provider visible.
The screenshots prove opening, not saving a provider or model usability. The current close/return replay was blocked after the onboarding fixture advanced; component lifecycle coverage is separate. To finish QA, use a fresh isolated profile, open Models from welcome step 3, close native Settings and require Bot navigation to return; then repeat Home and failure-card entry points. The feature guide records this path and its gaps.
Initial CI found two external-entry fixtures that still created an unnamed generic dialog trigger. The exact failing 9-test command was reproduced locally (2 failed), then passed after naming those fixture controls Settings (9 passed). The four-file navigation suite passes 29 tests. No unsafe generic production-selector fallback was restored; CI for the follow-up head is pending.