Skip to content

fix(client): open native model settings through its named entry - #3241

Merged
DoodleBears merged 3 commits into
mainfrom
t3/issue-3222-fix
Oct 31, 2026
Merged

DoodleBears merged 3 commits into
mainfrom
t3/issue-3222-fix

Conversation

@DoodleBears

@DoodleBears DoodleBears commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Closes #3222 · delivery claim

Tasks: codex/local/01a191d8-2941-78f0-b560-5a779e027f81 (reproduction and fix), codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0 (independent PR and verification docs).

Why the change

Open model setup through the named native Settings entry instead of accidentally opening the mobile app dialog.

Special things to note

  • Merge risk: two-way door — revert these commits, without data repair; medium blast radius — shared Models/IM native-settings navigation and sidebar handoff, with misrouting or a stranded sidebar as the main risks; review named-control selection, cancellation, timeout and disposal.
  • Draft pending current rc.3 close/return, Home/failure-card paths and Human/native Desktop QA; no [Performance] Switching channels/conversations in Bot mode freezes renderer main thread at ~113% CPU (1.6.0 follow-up to #2413) #3214 performance changes, credential writes or model calls.
  • Real rc.3 first-run reproduction failed before and passed after with the same input. Parent standalone branch: 4 files / 29 tests pass; full typecheck, lint and changelog checks passed before the two-label test-only follow-up. Child combined baseline also passed build. Existing lint warnings remain unrelated.

Change outline

 Bot model setup action
-  first dialog trigger → Get mobile app
+  named Settings / Account menu → native Models
+  shared handoff → reveal native sidebar, preserve Bot mode
+  close / cancel / timeout / disposal → release observer and handoff

First-run Models — isolated DSH rc.3 Web Client, Chinese, 1440 × 900

Before — the model setup action opened the mobile app dialog.

Before: model setup opens the mobile app popup

After — the same action opens native Settings, Models, with Add model provider visible.

After: model setup opens native Models settings

The screenshots prove opening, not saving a provider or model usability. The current close/return replay was blocked after the onboarding fixture advanced; component lifecycle coverage is separate. To finish QA, use a fresh isolated profile, open Models from welcome step 3, close native Settings and require Bot navigation to return; then repeat Home and failure-card entry points. The feature guide records this path and its gaps.

Initial CI found two external-entry fixtures that still created an unnamed generic dialog trigger. The exact failing 9-test command was reproduced locally (2 failed), then passed after naming those fixture controls Settings (9 passed). The four-file navigation suite passes 29 tests. No unsafe generic production-selector fallback was restored; CI for the follow-up head is pending.

Issue: #3222
Agent-Task: codex/local/01a191d8-2941-78f0-b560-5a779e027f81
Issue: #3222
Agent-Task: codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7070163b-2e00-4bcd-8d0e-d441e12719f7
Commits

Reviewing files that changed from the base of the PR and between 6046cda and ee35bdf.

Files ignored due to path filters: 2
  • .github/pr-screenshots/3222/a.png is excluded by !**/*.png
  • .github/pr-screenshots/3222/b.png is excluded by !**/*.png
Files selected for processing: 11
  • .agents/skills/dsh-dev/SKILL.md
  • .agents/skills/verify-deepseekbot/features/README.md
  • .agents/skills/verify-deepseekbot/features/native-settings-handoff.md
  • changes/3222-native-model-settings-navigation.md
  • packages/client/src/client/bot-settings-open.ts
  • packages/client/src/client/index.ts
  • packages/client/test/bot-icon.test.ts
  • packages/client/test/external-entries.test.ts
  • packages/client/test/lark-settings-navigation.test.ts
  • packages/client/test/model-settings-navigation.test.ts
  • scripts/verification-inventory.json
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@DoodleBears

Copy link
Copy Markdown
Contributor Author

Review artifact status: an exact-head HTML explainer was generated for 8657b9e with five panels and zero writing warnings. It remains a local handoff, not a publicly accessible review artifact; browser rendering could not be verified because the browser bootstrap was unavailable. The GitHub before/after PNGs in the body both return HTTP 200 image/png. Runtime opening evidence, component tests, remaining close/return and native/Human QA are recorded separately in the body. No merge or release performed.

Issue: #3222
Agent-Task: codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0
@DoodleBears

Copy link
Copy Markdown
Contributor Author

Head update: ee35bdf supersedes the prior explainer head. Initial CI failed in two external-entry tests whose synthetic Settings buttons lacked accessible names. Reproduced locally: 2 failed / 7 passed; adding the real Settings name to both fixtures makes the same command 9/9 green and the four-file navigation suite 29/29 green. No generic production fallback was added. The local HTML explainer is refreshed for this exact head with zero writing warnings; public HTML/browser access remains unavailable. Existing before/after images stay pinned to their capture-containing commit. New CI and the documented runtime/Human QA remain pending.

@DoodleBears
DoodleBears marked this pull request as ready for review October 31, 2026 14:09
@DoodleBears
DoodleBears merged commit c857c2d into main Oct 31, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 首次引导第三步「打开模型设置」无反应,反而弹出「获取手机 APP」浮层

1 participant