Repository navigation
fix(client): exclude ineligible Bots from IM app pickers - #3243
Draft
DoodleBears wants to merge 2 commits into
Draft
DoodleBears wants to merge 2 commits into
DoodleBears wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
|
Exact-head review artifact: c9b91b4. A five-panel HTML explainer is saved in the local task handoff; no authorized public HTML hosting or working browser bootstrap was available, so public access and visual rendering remain unverified. It is not runtime evidence. The independent branch also passes full lint (existing warnings only). The PR remains draft pending provider-backed Create/Bind screenshots and native/Human QA; no merge or release performed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3220 · delivery claim
Tasks:
codex/local/01a191d8-2941-78f0-b560-5a779e027f81(reproduction and fix),codex/local/01a191cc-31b6-7271-bf8b-6ed6689e15d0(independent PR and verification docs).Why the change
Keep deleted and paused Bots out of IM app creation and binding pickers, including when a selected Bot becomes ineligible while the dialog is open.
Special things to note
Change outline
The independent branch passes 2 focused test files / 17 tests, root TypeScript, feature-map validation and changelog checks. The child also passed full lint/build and 123 Client tests on the combined current-main baseline. The regression exercises the real React component, including deletion while Bind is mounted.
UI capture blocker: the stock isolated rc.3 Profile advertises
apps: []andsetups: [], so Create app is intentionally unavailable. No fixture screenshot is presented as live UI proof. Review path: provide a qualified test IM setup provider or an unbound test app; open Create and Bind with one live Bot and one retained tombstone; verify only the live Bot appears. Delete or pause the selected test Bot while the picker is open and require its option to disappear and submission to disable. Confirm an existing paused binding retains its display name. This does not require production receiver access or a model call.