ci: skip no-mistakes-required check on fork#13
Merged
Conversation
The fork's delivery path (bin/fm-fork-deliver.sh) targets a local quality gate, not the no-mistakes pipeline, so this upstream-inherited check always fails red on fork PRs even when legitimately delivered. Guard the job on github.repository so it stays neutral here and re-activates automatically on the upstream repo, keeping the file merge-clean across future upstream integrations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
no-mistakes-requiredcheck, which fails on every fork PR.bin/fm-fork-deliver.sh, local quality gate) deliberately does not run the no-mistakes pipeline against this repo - that pipeline targets upstream, not the fork.github.repository == 'kunchenguid/firstmate'guard to the job's existingif:condition.kunchenguid/firstmate) with no other behavior change there.if:expression, no restructuring of the workflow.github.repositoryactually is upstream.What Changed
.github/workflows/no-mistakes-required.yml: addedgithub.repository == 'kunchenguid/firstmate' &&as the first clause of the job'sif:condition.Testing
yaml.safe_loadto confirm it is syntactically valid;actionlintwas not available in this environment.if:expression to confirm the guard is a simple boolean AND with the pre-existing bot-author exclusions, preserving existing behavior on the upstream repo.Full narrative / original brief
Neutralize the upstream-inherited
no-mistakes-requiredPR check on the Bre77/firstmate fork.Problem:
.github/workflows/no-mistakes-required.yml(inherited from upstream in the recent integration) fails on every fork PR because the fork's delivery path (bin/fm-fork-deliver.sh, local quality gate) deliberately does not use the no-mistakes pipeline - its gate targets upstream. Evidence: PR 11 and PR 12 both showed the red check; both were legitimately delivered.Fix: make the workflow skip (neutral/success) when it runs in this fork - e.g. a repository guard (
if: github.repository == 'kunchenguid/firstmate') on the job(s), so the file stays merge-clean with upstream and re-activates automatically for anyone whose repo IS upstream. Do not delete the file (deleting reintroduces a conflict on every future upstream integration).Verify: workflow YAML parses (actionlint or gh's parser if available), and the guard expression is the minimal change. State in the PR body that upstream integrations will merge this file cleanly.