Repository navigation
Align card headers with subgrid; tighten the first screen - #100
Merged
Merged
Conversation
…et the film plate peek above the fold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Exp. 03 eyebrow.
monthlyis back. At two-column widths (901-1100px) the eyebrow wraps to two lines; paired cards now share their header rows through CSS subgrid, so the rule, title, fact and links of Exp. 02/03 and Exp. 04/05 stay on the same lines instead of drifting apart. Guarded by@supports(grid-template-rows:subgrid); the featured card, the single-column layout and browsers without subgrid keep the flex layout.First screen. The hero was a full-viewport block with centered content, so wide screens showed mostly margin and the film plate sat a full screen below. CSS only, no new text:
100svh - 100px, minus up to 15vh (cap 150px)Measured (Playwright, this branch vs live main 45b5312)
The hook line stays above the fold wherever it was. No horizontal overflow and no console errors at any of the eight sizes.
Card headers at 901-1440px: within each pair the eyebrow height, rule, title, links and card height match (checked at 901, 940, 1024, 1090, 1100, 1200, 1440); no horizontal overflow from 360 to 1440.
Checks
typecheckandverify:staticpass locally; everything else is left to CI.Trade-off
15vhterm.