Skip and log for unrecognised values - #72
Merged
Merged
Conversation
Collaborator
|
This seems reasonable, though I wonder if it should be a configurable option? i.e. there could well be use cases where one should fail when there is unexpected data. |
Collaborator
Author
Good shout, has been changed! |
Collaborator
|
I wondered whether this also needed to handle non-Zephyr usage (i.e. not just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the EEPROM sees a TS ID that is no longer recognised by the firmware (eg if a value was saved to the EEPROM, then the firmware is updated to a new version that removes said value) then it stops trying to interpret the rest of the EEPROM.
This MR proposes that we should instead just skip this value, log a warning and carry on processing the rest of the EEPROM in this case