Repository navigation
Declare the scala-library for the Bifrost Scala kernel (#297) - #298
Merged
Merged
Conversation
The Bifrost Scala kernel now materializes adapters/bifrost/dependency-evidence/scala/pom.xml as each case workspace's pom.xml. The pom declares org.scala-lang:scala-library:2.13.16, so Bifrost activates the Scala standard-library model from exact local evidence. Before this, a fixture that calls scala.collection.mutable.Map was analyzed against no library model, because Bifrost activates that model only from a build declaration. This is BrokkAi/bifrost-dev#3130 option B1; the owner decided on 2026-10-29 to land it into the v0.9.2 refresh. - The pom is Bifrost adapter configuration, not case data. Only the Scala kernel run materializes it, so smoke and other runs are unchanged. It is hashed into the run's configuration_hash, through both the run loop and bifrost_policy_paths. - reports/bifrost-scala-kernel.json therefore drifts until the v0.9.2 Scala group reruns. It is recorded in KNOWN_STALE_CONFIGURATIONS against #297. Entries now carry their own tracking issue, instead of every message citing the closed #138. - docs/scala-kernel.md records the evidence and the host prerequisite: the jar and its sources jar in ~/.m2, which the runner never downloads. It also records that all 70 Scala fixtures compile offline with Scala 2.13.18; the 2.13.16 compiler was not cached locally. - docs/v0.9.2-release-contract.md records the amendment: one group's configuration changes, that group reruns under a fresh attempt namespace, and earlier Scala attempts stay retained but unpublished. Validation: cargo test 308/308; cargo run -- validate; cargo run -- validate-reports (92 reports, 1 known-stale); cargo fmt --check. With a Bifrost build carrying bifrost-dev#8010 and #8030 and the real 2.13.16 jars, the map-iteration pair activates the pack. Its blocker moves from unsupported (assignments) to unsupported (deferred_execution): the comprehension's callback execution, which remains open in bifrost-dev #4295. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CI's isolated tag checkout validates the released v0.9.0 reports with this branch's binary. Configuration derivation then tried to read the new pom.xml, which the tag's tree does not contain. The evidence joined the Scala kernel's configuration with the v0.9.2 pin (bifrost 0.14.0), so a report from an earlier pin now hashes without it, as CodeQL's version-scoped closures do. The committed bifrost 0.11.4 Scala report therefore matches again, and the KNOWN_STALE_CONFIGURATIONS entry and its (stem, issue) restructuring are reverted. #297 still tracks the owed v0.9.2 Scala group rerun. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements BrokkAi/bifrost-dev#3130 option B1. The owner decided on 2026-10-29 to land it into the v0.9.2 refresh. Tracking issue for the owed rerun: #297.
What changed
adapters/bifrost/dependency-evidence/scala/pom.xml, declaringorg.scala-lang:scala-library:2.13.16. The Bifrost Scala kernel copies it into every case workspace aspom.xml, so Bifrost activates the Scala standard-library model from exact local evidence. Only the Scala kernel run materializes it (bifrost_dependency_evidence_for).configuration_hash, through both the run loop andbifrost_policy_paths.pom.xmlis part of the configuration from the v0.9.2 Bifrost pin (bifrost 0.14.0) on. A report from an earlier pin hashes without it, as CodeQL's version-scoped closures do, so the committedbifrost 0.11.4Scala report and the released tag still validate. Re-run the v0.9.2 Bifrost Scala kernel with scala-library dependency evidence #297 tracks the owed v0.9.2 Scala group rerun.docs/scala-kernel.md: documents the evidence and the host prerequisite.scala-library-2.13.16.jarand-sources.jarmust be in~/.m2; the runner never downloads them.docs/v0.9.2-release-contract.md: amendment. One group's configuration changes and that group reruns under a fresh attempt namespace. Earlier Scala attempts stay retained but unpublished. No case, fixture, policy or other analyzer changes.Why
Bifrost activates a library model only from build evidence, and a case workspace containing only the
.scalafixture yields none. The Scala map-iteration pair, for example, was analyzed against noscala.collection.mutable.Mapmodel at all.Validation
cargo test: 308/308, including the newscala_kernel_materializes_and_hashes_its_dependency_evidence.cargo run -- validate,cargo run -- validate-reports(92 reports, at the first commit), andcargo fmt --checkall pass.~/.m2. The scala-library pack activates, and the blocker moves fromunsupported (assignments)tounsupported (deferred_execution). That is the comprehension's callback execution, which stays open in bifrost-dev#4295.The version-scope fix (second commit) was validated by
cargo buildonly. Restoring the evidence to rerunvalidate-reportsand the tests locally needs about 6 GB, and this host is low on disk, so CI runs them.Not done here
The Scala kernel group has not been rerun inside the v0.9.2 execution framework. That needs the pinned Bifrost release and the refresh's ≥125 GiB disk precondition; this host has 99 GiB free. It is tracked by #297.
🤖 Generated with Claude Code