Uilanding by pitypec · Pull Request #47 · BuildForSDG/Team-064-Frontend

pitypec · 2020-05-27T11:16:42Z

Description

The page serves as the landing page and also the login page for both the admin and customer
Boostrap
react-bootstrap

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.

Checklist:

[x ] My code follows the style guidelines of this project
[x ] I have performed a self-review of my own code
[x ] I have commented my code, particularly in hard-to-understand areas
[x ] I have added necessary inline code documentation
I have added tests that prove my fix is effective and that this feature works
New and existing unit tests pass locally with my changes

johnsonfash · 2020-05-28T05:34:33Z

i have checked the repository:

Your: import App from './App', is incorrect and threw errors, i had to figure it was ./app not ./App
Listgroup is undefined at components/Navigations/Sidedrawer/Side.js on trying to access dashboard.
Although a placeholder, review your screen/profile.js. invalide class still present.
please import the appropriate bootstrap Form @ screen/adminlogin.js.
Fix donate button falling out of view on LandingPage.

abiodunaremu · 2020-05-30T08:17:14Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 30
           

Clones added
============
- src/components/Screens/Auth/Signup.js  4
- src/components/Screens/Auth/AdminLogin.js  3
- src/components/Screens/Auth/AdminDashboard.js  1
- src/containers/LandingPage/index.js  6
- src/components/Screens/Auth/AgentSignUp.js  4
- src/components/Screens/Auth/AgentDasboard.js  1
         

Clones removed
==============
+ src/components/Navigations/NavBar/index.js  -1

See the complete overview on Codacy

abiodunaremu · 2020-05-30T08:17:15Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:15Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:16Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:17Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:18Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:19Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Missing file extension for "./node_modules/react"

abiodunaremu · 2020-05-30T08:17:20Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:21Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:22Z

+              <Container fluid>
+                <Suspense fallback={this.loading()}>
+                  <Switch>
+                    {routes.map((route, idx) => {


Issue found: Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.

abiodunaremu · 2020-05-30T08:17:23Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:24Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:25Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:25Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:26Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:27Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Missing file extension for "./node_modules/react"

abiodunaremu · 2020-05-30T08:17:28Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Missing file extension for "./node_modules/react"

abiodunaremu · 2020-05-30T08:17:29Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:30Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:31Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:32Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:33Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: 'React' is defined but never used.

abiodunaremu · 2020-05-30T08:17:34Z

@@ -0,0 +1 @@
+import React from 'react';


Issue found: Newline required at end of file but not found.

abiodunaremu · 2020-05-30T08:17:35Z

@@ -0,0 +1 @@
+import React from './node_modules/react';


Issue found: Missing file extension for "./node_modules/react"

abiodunaremu · 2020-05-30T08:17:36Z

@@ -0,0 +1,32 @@
+import React from 'react';
+
+const Dashboard = React.lazy(() => import('./views/Dashboard/CustomerDashboard'));


Issue found: Dependency cycle detected.

abiodunaremu · 2020-05-30T08:17:37Z

+import { Nav, NavItem, NavLink } from 'reactstrap';
+
+// eslint-disable-next-line no-unused-vars
+const AppSidebar = ({ navConfig, ...props }) => {


Issue found: Unexpected block statement surrounding arrow body; move the returned value immediately after the =>.

pitypec and others added 6 commits May 10, 2020 05:05

check that route worked

24b5b78

fix: adjusted the routes issues

08564a4

need check done

dc89dfa

customer login page

e86cf77

customer signup page

f82f3d7

made changes spotted by codacy

fac7269

pitypec linked an issue May 27, 2020 that may be closed by this pull request

[@A] Create Customer Sign up page #5

Open

pitypec added 7 commits May 27, 2020 13:19

further changes made to adhere to codacy

03613b2

new changes made to app.css and routes.js

5753498

further changes made as pointed out by codacy

0894422

further changes made

ae00737

made further reveiws

39eb20a

further reveiew done

d44bad5

changes made to the package.json

4198fbd

pitypec linked an issue May 27, 2020 that may be closed by this pull request

[@A] Create Register Administrator Page #13

Open

festus14 previously approved these changes May 29, 2020

View reviewed changes

Dashboard components added

9e3c10a

pitypec dismissed festus14’s stale review via 9e3c10a May 30, 2020 08:15

abiodunaremu reviewed May 30, 2020

View reviewed changes

		@@ -0,0 +1 @@
		import React from 'react'; No newline at end of file

		@@ -0,0 +1 @@
		import React from './node_modules/react'; No newline at end of file

		@@ -0,0 +1,32 @@
		import React from 'react';

		const Dashboard = React.lazy(() => import('./views/Dashboard/CustomerDashboard'));

Uh oh!

Conversation

pitypec commented May 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Checklist:

Uh oh!

johnsonfash commented May 28, 2020

Uh oh!

abiodunaremu commented May 30, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pitypec commented May 27, 2020 •

edited

Loading