Final by johnsonfash · Pull Request #48 · BuildForSDG/Team-064-Frontend

johnsonfash · 2020-06-16T05:30:20Z

Description

Please include a summary of the change and relevant motivation and context.
List any dependencies that are required for this change.

All pull requests should be related to open issues. Indicate the issue(s) bellow and remove this line:
Fixes #(issue number 1) #(issue number 2 if applicable)

How Has This Been Tested?

Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code etc.

Screenshots (if applicable, else remove this line / section)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added necessary inline code documentation
I have added tests that prove my fix is effective and that this feature works
New and existing unit tests pass locally with my changes

abiodunaremu · 2020-06-16T10:37:53Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 478
           

Complexity increasing per file
==============================
- src/views/Order/Summary.js  1
- src/views/Pages/Login/Login.js  6
- src/views/Order/Address.js  1
- src/views/Map/CustomerMap.js  4
- src/components/Screens/Orders/index.js  1
- src/containers/DefaultLayout/DefaultHeader.js  1
- src/containers/DefaultLayout/__tests__/DefaultLayout.test.js  1
- src/store/actions/community.js  1
- src/views/Order/index.js  1
- src/store/reducers/community.js  4
- src/views/Pages/Register/Register.js  7
- src/views/Community/View.js  9
- src/views/Pages/Accout/index.js  1
- src/views/Pages/Message/RegMessage.js  3
- src/routes.js  1
- src/views/Community/Editor.js  12
- src/containers/DefaultLayout/DefaultLayout.js  4
- src/views/Community/index.js  7
- src/views/History/index.js  1
- src/containers/DefaultLayout/__tests__/DefaultHeader.test.js  1
- src/components/Payment/index.js  4
- src/store/reducers/user.js  2
- src/containers/DefaultLayout/DefaultFooter.js  1
- src/views/Pages/Register/Register.test.js  1
- src/views/Map/AgentMAp.js  3

See the complete overview on Codacy

abiodunaremu · 2020-06-16T10:38:16Z

+    let google = window.google;
+    let addRoute = this.addRoute;
+    const handleLocationError = this.handleLocationError;
+    let processSVData = this.processSVData;


Issue found: 'processSVData' is never reassigned. Use 'const' instead.

abiodunaremu · 2020-06-16T10:38:17Z

+    let { loading, error, errorMessage, userData } = this.props.userData;
+    error === 'true' && errorMessage !== '' ? (f = errorMessage) :
+      (userData.errorcount !== '0' ? (f = userData.error) : (f = ''));
+    loading === 'done' ? (u = 'Login') :


Issue found: Do not nest ternary expressions.

abiodunaremu · 2020-06-16T10:38:18Z

+    let val = e.target.value.replace(/\D/g, '');
+    switch (e.target.id) {
+      case 'cardNumber':
+        let addSpace = val.replace(/(.{4})/g, '$1 ').trim();


Issue found: Unexpected lexical declaration in case block.

abiodunaremu · 2020-06-16T10:38:19Z

+      panorama.setVisible(true);
+
+      marker.addListener('click', () => {
+        let markerPanoID = data.location.pano;


Issue found: 'markerPanoID' is never reassigned. Use 'const' instead.

abiodunaremu · 2020-06-16T10:38:20Z

+const mapStateToProps = (state) => {
+  return {
+    communityData: state.communityData
+  }


Issue found: Missing semicolon.

abiodunaremu · 2020-06-16T10:38:22Z

+const mapStateToProps = (state) => {
+  return {
+    communityData: state.communityData
+  }


Issue found: Missing semicolon.

abiodunaremu · 2020-06-16T10:38:23Z

+import React, { Component } from 'react';
+import {
+  Button, Card, CardBody, Col, Container, Form, Input, InputGroup
+  , InputGroupAddon, InputGroupText, Row, Nav, NavItem, NavLink, TabContent, TabPane


Issue found: ',' should be placed last.

abiodunaremu · 2020-06-16T10:38:24Z

+  }
+}
+
+


Issue found: More than 1 blank line not allowed.

abiodunaremu · 2020-06-16T10:38:25Z

+    });
+  }
+
+  render() {


Issue found: Expected 'this' to be used by class method 'render'.

abiodunaremu · 2020-06-16T10:38:26Z

@@ -0,0 +1,123 @@
+import React, { Component } from 'react'
+import {
+  Button,


Issue found: 'Button' is defined but never used.

abiodunaremu · 2020-06-16T10:38:27Z

+        dispatch(fetchCommunityDataFailure(errorMessage))
+      })
+
+  } catch (error) {


Issue found: Block must not be padded by blank lines.

abiodunaremu · 2020-06-16T10:38:28Z

+      let bounds = new google.maps.LatLngBounds();
+      places.forEach((place) => {
+        if (!place.geometry) {
+          console.log("Returned place contains no geometry");


Issue found: Strings must use singlequote.

abiodunaremu · 2020-06-16T10:38:29Z

+
+  render() {
+    const mystyle = {
+      backgroundColor: "white",


Issue found: Unexpected trailing comma.

abiodunaremu · 2020-06-16T10:38:30Z

+import { Col, Container, Row } from 'reactstrap';
+import { withRouter } from 'react-router-dom';
+
+


Issue found: More than 1 blank line not allowed.

abiodunaremu · 2020-06-16T10:38:31Z

+import { sendCommunityData } from '../../store/actions/community';
+import Payment from '../../components/Payment';
+import { isAuthUserType } from '../../services/Auth';
+import { Link } from 'react-router-dom';


Issue found: 'Link' is defined but never used.

abiodunaremu · 2020-06-16T10:38:32Z

+  }
+
+  componentDidUpdate(prevProps) {
+    let { userData } = this.props.userData;


Issue found: 'userData' is never reassigned. Use 'const' instead.

abiodunaremu · 2020-06-16T10:38:33Z

+    infoWindow.open(map);
+  }
+
+  render() {


Issue found: Expected 'this' to be used by class method 'render'.

abiodunaremu · 2020-06-16T10:38:33Z

+
+  render() {
+    let { searchBox, addressBox } = this.state
+    console.log(addressBox)


Issue found: Unexpected console statement.

abiodunaremu · 2020-06-16T10:38:34Z

@@ -0,0 +1,26 @@
+import React, { Component } from 'react';
+import PropTypes from 'prop-types';


Issue found: 'prop-types' should be listed in the project's dependencies. Run 'npm i -S prop-types' to add it

abiodunaremu · 2020-06-16T10:38:35Z

+      markers = [];
+
+      // For each place, get the icon, name and location.
+      let bounds = new google.maps.LatLngBounds();


Issue found: 'bounds' is never reassigned. Use 'const' instead.

abiodunaremu · 2020-06-16T10:38:36Z

+
+  handleLocationError(browserHasGeolocation, infoWindow, pos) {
+    infoWindow.setPosition(pos);
+    infoWindow.setContent(browserHasGeolocation ?


Issue found: '?' should be placed at the beginning of the line.

abiodunaremu · 2020-06-16T10:38:37Z

+      if ((data.file_name === imagePreviewUrl) && (data.location === location) && (data.amount === amount) && (data.details === details)) {
+        this.clsBtn.current.style.display = "block";
+        return null
+      } else {


Issue found: Unnecessary 'else' after 'return'.

abiodunaremu · 2020-06-16T10:38:38Z

+        if (userData.status === 'successful' && userData.errorcount === '0') {
+          authenticateUser(userData.email, 'customer')
+          this.props.history.push('/order')
+        };


Issue found: Unnecessary semicolon.

abiodunaremu · 2020-06-16T10:38:39Z

+    return (
+      <div className="app">
+        <AppHeader fixed>
+          <DefaultHeader onLogout={e => this.signOut(e)} />


Issue found: Expected parentheses around arrow function argument.

abiodunaremu · 2020-06-16T10:38:39Z

+  { path: '/order', exact: true, name: 'Order', component: Order },
+  { path: '/account', exact: true, name: 'Account', component: Account },
+  { path: '/community', exact: true, name: 'Community', component: Community },
+  { path: '/history', exact: true, name: 'History', component: History },


Issue found: Expected a line break after this opening brace.

johnsonfash requested review from abiodunaremu, festus14 and pitypec June 16, 2020 05:30

abiodunaremu reviewed Jun 16, 2020

View reviewed changes

Comment thread src/views/Community/index.js Outdated

}

}

abiodunaremu Jun 16, 2020

Copy link
Copy Markdown

Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: More than 1 blank line not allowed.

abiodunaremu reviewed Jun 16, 2020

View reviewed changes

Merge pull request #50 from BuildForSDG/feature/appproperties

8d95c6a

festus14 approved these changes Jun 21, 2020

View reviewed changes

johnsonfash force-pushed the final branch from d3bc3c4 to 8d95c6a Compare July 1, 2026 08:43

		import { Col, Container, Row } from 'reactstrap';
		import { withRouter } from 'react-router-dom';

		@@ -0,0 +1,26 @@
		import React, { Component } from 'react';
		import PropTypes from 'prop-types';

Uh oh!

Conversation

johnsonfash commented Jun 16, 2020

Description

How Has This Been Tested?

Screenshots (if applicable, else remove this line / section)

Checklist:

Uh oh!

abiodunaremu commented Jun 16, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants