Repository navigation
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
|
Thanks for the update and follow-up details. This adds an owner-only read-only discussion panel and changes how disabled comments appear across Clips history, so please get Shomix's Clips-owner review before approval. |
|
Alice confirmed the comments-off policy on Oct 22: viewers lose access to saved comments everywhere, while owners retain read access. This PR implements that policy, including the owner read-only panel. It will remain open pending the requested Clips-owner review and your approval. |
|
Thanks for the update and policy confirmation. I checked the owner share-link redirect and the documented cleanup exception; this still needs Shomix’s Clips-owner review before approval. |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental review summary
The latest update separates canReact from canComment, preserving the independent reaction setting while retaining role and preview exclusions. The added player-route tests exercise the comments-off/reactions-on interaction, reactions-off visibility, preview restriction, and outgoing mutation payload; the current fix also resolves the previously open reaction-control finding, whose thread I cleared before this review. I found no new runtime defect. One low-severity test-coverage opportunity was reported: the route test uses a mocked mutation and verifies the emitted payload, not database persistence. Risk remains high for the overall PR because its underlying changes govern access to saved discussion. The review system may filter this low-severity observation.
Findings
- No new runtime issues found.
- ⚪ Low: the route-level reaction test does not itself verify action persistence.
🧪 Browser testing: Skipped — the browser-test-planner agent is unavailable in this environment. The PR description reports separate E2B real-UI verification.

Turning comments off hides saved comment text from viewers in notification previews and recording search. The owner retains access through the comment list, player, and screen context, with a read-only discussion panel. Authenticated owners entering through share links are redirected to that player.
Recording reactions retain their independent setting when comments are off. The signed-in player header preserves its existing role and preview exclusions.
Creation, replies, edits, comment reactions, and resolution remain disabled. Authorized deletion retains the approved cleanup exception, subject to the existing author/editor, Trash, and expiry checks.
Stacked on #8059. This implements the clarified comments-off policy separately; it will target
mainafter the base PR merges.Verification:
No schema or stored-data changes.