Repository navigation
Fix Design image export with external stylesheets and improve promo typography - #8118
Conversation
|
Here's a visual recap of what changed: Open the full interactive recap |
|
Addressed the inherited-error coverage suggestion in f3f661f: both Chromium capture flows now explicitly verify that pre-existing canvas and embedded-document failures return |
|
Replayed five supplied 1000×1000 promo frames with Google Fonts and inline SVGs through the real PNG export pipeline: all five reproduced For the latest low-severity no-CORS-header coverage suggestion, I’m retaining the existing scoped regression coverage: failed resource fetches remain hard failures and a failed stylesheet is also checked on reprocessing. The change does not bypass CORS or resource validation; no additional runtime change is needed. |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
Reviewed the latest PR #8118 diff (325 changed lines across nine files). The new change adds a mock for getScopedTransactionDbExec to a run-store test; reviewers confirmed it follows neighboring test patterns and does not alter runtime behavior. Design export continues to preserve CSSOM-opaque stylesheet links for the inlining pass and to surface missing-resource and inherited snapshot failures. The inherited-failure behavior is now explicitly covered. No new actionable bugs were found. Risk remains standard because of the export failure-contract change.
🧪 Browser testing: Not run — browser-test-planner is unavailable in this environment; the dev server is running.

PNG and PDF export can reject a fully loaded external stylesheet when the browser blocks CSSOM access, even when the export bridge can fetch and inline it. Preserve those linked stylesheets through mandatory resource inlining, while retaining hard failures for missing resources and inherited export errors.
Update Design’s existing generation guidance for promotional artwork: follow supplied brand tokens, choose type sizes and weights for the canvas, and inspect legibility at the intended display size. Record the corresponding readability pattern in the existing friction report. Also repair a stale core test database mock exposed by CI; production agent behavior is unchanged.
Validation:
This is a scoped follow-up to #8086. The original reported agent-run causes remain unverified pending authenticated debug access; this change does not alter run budgets.