Skip to content

Fix the reaped-run tracking spec's db mock on main - #8120

Merged
mwang1026 merged 1 commit into
mainfrom
fix-reaped-run-tracking-mock
Oct 23, 2026
Merged

mwang1026 merged 1 commit into
mainfrom
fix-reaped-run-tracking-mock

Conversation

@mwang1026

Copy link
Copy Markdown
Contributor

run-store.reaped-run-tracking.spec.ts (#7971) mocks ../db/client.js without getScopedTransactionDbExec. #8086 merged after it and calls that function from withFencedExecutionWrite. Each passed on its own, but on main "does not report a repair the run's own process makes of its own row" now fails with No "getScopedTransactionDbExec" export is defined on the "../db/client.js" mock. Main doesn't run core tests on push, so any PR whose core shard includes this spec fails.

This adds the same getScopedTransactionDbExec: () => undefined that #8086 added to the other run-store spec mocks. The spec fails on main without it and passes with it (16/16).

@shawnmcclelland
shawnmcclelland self-requested a review October 23, 2026 16:20

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

PR #8120 adds the missing getScopedTransactionDbExec export to the Vitest mock in run-store.reaped-run-tracking.spec.ts. This addresses the reported integration failure where the execution-fence code imports that function while the spec replaces the database client module. The mock returns undefined, matching the production function's behavior when no scoped transaction executor is active; the test continues to exercise the fallback transaction path and its existing assertions are unchanged.

Risk assessment: Low (test-only change). The two independent code-review passes found no clear bugs or assertion weakening. The change is narrowly scoped and consistent with the needed test setup.

🧪 Browser testing: Skipped — test-only change, no user-facing browser impact.

@mwang1026
mwang1026 enabled auto-merge (squash) October 23, 2026 16:26
@mwang1026
mwang1026 merged commit 2d78548 into main Oct 23, 2026
88 of 90 checks passed
@mwang1026
mwang1026 deleted the fix-reaped-run-tracking-mock branch October 23, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants