Repository navigation
Fix the reaped-run tracking spec's db mock on main - #8120
Conversation
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
PR #8120 adds the missing getScopedTransactionDbExec export to the Vitest mock in run-store.reaped-run-tracking.spec.ts. This addresses the reported integration failure where the execution-fence code imports that function while the spec replaces the database client module. The mock returns undefined, matching the production function's behavior when no scoped transaction executor is active; the test continues to exercise the fallback transaction path and its existing assertions are unchanged.
Risk assessment: Low (test-only change). The two independent code-review passes found no clear bugs or assertion weakening. The change is narrowly scoped and consistent with the needed test setup.
🧪 Browser testing: Skipped — test-only change, no user-facing browser impact.
run-store.reaped-run-tracking.spec.ts(#7971) mocks../db/client.jswithoutgetScopedTransactionDbExec. #8086 merged after it and calls that function fromwithFencedExecutionWrite. Each passed on its own, but on main "does not report a repair the run's own process makes of its own row" now fails withNo "getScopedTransactionDbExec" export is defined on the "../db/client.js" mock. Main doesn't run core tests on push, so any PR whose core shard includes this spec fails.This adds the same
getScopedTransactionDbExec: () => undefinedthat #8086 added to the other run-store spec mocks. The spec fails on main without it and passes with it (16/16).