Repository navigation
Respect footage takedowns in Clip thumbnails - #8313
Conversation
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary
PR #8313 updates the Clips thumbnail route so a Clip backed by separate footage returns 404 when that footage is marked taken_down. The check is applied while loading the footage, before the thumbnail route can select static or animated bytes from cache, storage, or a remote source. This is a high-risk access-control change because it enforces takedown policy for media content.
The approach is sound and preserves the existing Clip access checks. The added tests cover both viewer and owner roles, verify that neither remote fetch nor S3 access occurs for taken-down footage, and retain coverage for a taken-down parent Clip with healthy footage. Two independent reviews found no actionable issues in the changed lines. No UI files or user-facing flows changed.
Findings
No actionable findings.
🧪 Browser testing: Skipped — PR only modifies backend route logic, tests, and changelog; no UI impact.
|
Here's a visual recap of what changed: Open the full interactive recap |

When a Clip uses separate footage, a takedown on that footage can leave its thumbnail available even though video serving refuses it. This change checks the footage takedown before returning either static or animated thumbnail bytes. A takedown returns Not found for viewers and owners, using the same policy as video access.
The route now projects the footage failure code and refuses taken-down footage before touching cached images, storage or remote fetches. Existing parent-Clip access, password, expiry and Trash checks stay in place.
Verification:
This follows the standalone video fix in #8291. It does not depend on the comment-access stack.