fix: guard LOG_FILE_PATH against handlers without baseFilename (fixes #131)

[charlesaurav13]

Summary

• BusKill.__init__ hard-coded logger.root.handlers[0].baseFilename on line 227
• pytest replaces the root handler with _LiveLoggingNullHandler, which has no baseFilename attribute, so every test that instantiates BusKill() crashed with AttributeError
• Fixed by using getattr(handler, 'baseFilename', None) and also guarding against an empty handlers list

Changes

src/packages/buskill/__init__.py line 227:

# before
self.LOG_FILE_PATH = logger.root.handlers[0].baseFilename

# after
handler = logger.root.handlers[0] if logger.root.handlers else None
self.LOG_FILE_PATH = getattr(handler, 'baseFilename', None)

Test plan

• Instantiate BusKill() inside a pytest test — no longer raises AttributeError
• Normal runtime behaviour unchanged: LOG_FILE_PATH still resolves to the log file path when a FileHandler is configured

Closes #131

[github-actions]

INFO: No unicode characters found in PR's commits

(source)

[maltfield]

Thanks for the PR :)

Please note that this repo does not accept contributions that use AI

Can you please tell us if you wrote this code, comments, and PR contents entirely by yourself? Or if you used AI for any part of it?