Log system instead of printf and fprintf(stderr, ...)

[Purplesmaug96]

Only tested it on desktop/sdl3, seems to work fine there
Logs to ./butterscotch.log by default

[Purplesmaug96]

can i please use dup2 or something to redirect stdout/err to a file

[Un1q32]

What use case is there? Maybe for other backends where stdout is less accessible like mobile or consoles it would make sense, but for the desktop backend? why?

[Un1q32]

Oh wait, is it windows? its windows isnt it.

[Purplesmaug96]

mainly just want to be able to view it in my ide without "./butterscotch 2>&1 | tee out.log"
Edit: no i use arch (btw) but if i ever am forced to use butterscotch on windows it would be useful, although you can get it to display a second terminal window for stdout

[Un1q32]

What fucked up and evil IDE do you have that won't show you stdout?!??!

[Un1q32]

Doesn't every IDE have an integrated terminal or at least launches a terminal along with the app?

[Purplesmaug96]

i use vscodium and just launch my stuff on konsole normally

[Un1q32]

I used to use vscode it has an integrated terminal, why not just use that?

[Purplesmaug96]

too small, if i make it bigger it takes up the code space
not on a second monitor
i think its sandboxed so wont work with msvc via wine

[Un1q32]

Can't you configure vscode to launch an external terminal?

[Purplesmaug96]

probably but i dont wanna it works fine as is

[Un1q32]

Just use tee, setup an alias in your shell to make it easier to type. alias bscotch='./butterscotch 2>&1 | tee out.log'

[Purplesmaug96]

nah I'll just deal with there not being a log file or add a temporary write to file shim thing

[Un1q32]

unused?

[Purplesmaug96]

yeah forgot to remove it

[Un1q32]

Since you need to check if stdout is a tty for weather color should be enabled, and because color might not be desirable on some platforms, you should make color get handled in platformLog instead of in the dedicated log functions.

[Un1q32]

Here's a better platformLog implementation actually

void platformLog(const logType type, const char *format, va_list va) {
    FILE *out = stderr;
    switch (type) {
        case LOG_TYPE_NORMAL:
            out = stdout;
            break;
        case LOG_TYPE_WARNING:
            fputs("\033[33mWarning:\033[0m ", out);
            break;
        case LOG_TYPE_ERROR:
            fputs("\033[31mError:\033[0m ", out);
            break;
    }
    vfprintf(out, format, va);
}

This also properly resets the color which wasn't being done before.