feat: add confetti animation on game win - #20
Open
DaniilSyzenko wants to merge 2 commits into
Open
Conversation
BySplashGm
reviewed
May 12, 2026
BySplashGm
left a comment
Owner
There was a problem hiding this comment.
Great contribution overall — the widget lifecycle handling, dispose, and the custom star shape are all well done.
One visual bug to fix before merging: the stars accumulate at the emission point rather than spreading across the screen. Two things causing this:
blastDirectionality: BlastDirectionality.explosiveandblastDirection: -pi / 2conflict — in explosive mode the blast direction is ignored. Pick one: eitherexplosive(all directions) ordirectionalwith your-pi / 2anglegravity: 0.05is very low, so particles float in place instead of falling — try something around0.2–0.3
A directional upward fountain from the center with higher gravity should give a clean result.
Author
|
Hi, can I still work on this? |
Owner
|
sure! i'll reopen your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a confetti celebration animation on game win when the GameSummaryScreen loads.
Fixes #5