Crash when trying to map a custom SDO into a TPDO. #211

Activity

1. henri62

   added

   bugSomething isn't workingSomething isn't working

   on Dec 18, 2025
2. henri62 commented on Dec 18, 2025

   

   henri62

   on Dec 18, 2025

   Last edited by henri62

   Author

   More actions

   In the attached file, try to adjust SDO 0x1A62, Sub 0x01 (TPDO 99 mapping parameter) to 0x20000140.
   It crashes or it first says "Not mappable OD entry en0x2000.0x01" before it crashes.

   It will save something, but when I open the file I get this:

   System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
   Parameter name: ColumnSpan
      at SourceGrid.Cells.Cell.set_ColumnSpan(Int32 value)
      at ODEditor.DevicePDOView2.UpdatePDOinfo(Boolean updatechoices) in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\DevicePDOView2.cs:line 472
      at ODEditor.DeviceView.dispatch_updatePDOinfo() in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\DeviceView.cs:line 99
      at ODEditor.MyTabUserControl.doUpdatePDOs() in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\MyTabUserControl.cs:line 45
      at ODEditor.DeviceODView.PopulateObjectLists(EDSsharp eds_target) in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\DeviceODView.cs:line 194
      at ODEditor.DeviceView.dispatch_updateOD() in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\DeviceView.cs:line 110
      at ODEditor.ODEditor_MainForm.openXDDfile(String path) in D:\a\CANopenEditor\CANopenEditor\EDSEditorGUI\Form1.cs:line 366
   

   And the editor is empty.

   cleanopen-geesinknorba.zip

   If I edit line 2276 and remove the 0x20000140 from <q1:defaultValue value="0x20000140" /> into <q1:defaultValue value="0x0" /> the file can be opened again.

   Note that SDO 0x2000 type suddenly changes from OCTET_STRING to DOMAIN?

   I tried to use a standard object ID of 0x9FFF too, does not matter, still crashes. It looks that a TPDO mapping to an OCTET_STRING is causing the problem.

   Workaround:
   I worked around this problem now by making an manufacturer specific object 0x2000 with 8 sub entries of 8 bytes. The map all the bytes individually into the TPDO mapping parameters.
3. nimrof commented on Dec 21, 2025

   

   nimrof

   on Dec 21, 2025

   Collaborator

   More actions

   Thanks for the good bug report @henri62
   A different workaround is to set the default value for OCTET_STRING entry so the length is 8.
   That works for me.

   Need a little help here for permanent fix @trojanobelix @CANopenNode

   This happens because Sizeofdatatype for OCTET_STRING returns 0 if default values is not filled with something, that crashes the gui because the pdo mapping does not support odEntry of size 0

   fix suggestion:

   • Include prop.CO_stringLengthMin here:
     https://github.com/CANopenNode/CANopenEditor/blob/main/libEDSsharp/eds.cs#L1481
     That makes it easier to set the size instead of using default value
   • Set a minimum size of odEntry to 1bit in the pdo mapping, that should (hopefully) indicate to the user that something needs to be checked out.
     Alternatively we could not list odEntry with size 0, but that does not indicate to the use whats wrong to the user.
     A different alternative is to set min bit size to 1, but also show a pop-up box explaining why it is size 1

   Also: should domain be mappable to pdo?
4. trojanobelix commented on Dec 26, 2025

   

   trojanobelix

   on Dec 26, 2025

   Collaborator

   More actions

   Maybe it is enought to display a Message?
   if (mappingentry.width == 0){ MessageBox.Show(string.Format("Nothing to map in 0x{0:X}!\r\nThe Object to map has a width of 0.\r\n", slot.ConfigurationIndex)); break; }

   DS301 allows length of the object in bit from 1..40h => 8bytes = 64 bit. It does not really make sense to map a domain, as it is normally used for lage data (IMHO). But can not find that it is forbidden (if sizeof is 8 bytes or less)
5. trojanobelix commented on Dec 28, 2025

   

   trojanobelix

   on Dec 28, 2025

   Collaborator

   More actions

   @CANopenNode Janez, do you know whether DS301 allows mapping? AI tells me that all strings and domains must not be mapped, but when you look at the sources, there isn't much information. According to AI, only variables with a fixed length may be mapped. Which makes sense, in my opinion. On the other hand, canEDS doesn't complain during testing if you map STRINGS or DOMAIN.
6. henri62 commented on Dec 28, 2025

   

   henri62

   on Dec 28, 2025

   Author

   More actions

   I could not find a reference too. Mapping DOMAINS looks silly/useless too. All other types should be mappable, if they fit, to my opinion.

   Only dummy/void entries look restricted in CiA301. It says in paragraph 7.4.7.1
   I quote: "The static data types are placed in the object dictionary for definition purposes only. Indices in the
   range from 0001h to 0007h, 0010h, from 0012h to 0016h, and from 0018h to 001Bh may be mapped in
   order to define the appropriate space in the RPDO as not being used by this CANopen device (do not
   care). Other objects of the object code DEFTYPE and DEFSTRUCT shall not be mapped into
   RPDOs."

   This means that object types 0x9 VISIBLE_STRING and 0x0A OCTET_STRING cannot be mapped as void /dummy filler which is reasonable of coarse. For example: time of day uses a VOID4 dummy to align the bits to 16.

   But the mapping is not the real issue I started with, its the application crash when you try to map anything (wrong or not) that should not occur. The program should at least give an error. And the issue that the xdd file is not usable any more afterwards without editing.
7. trojanobelix commented on May 31, 2026

   

   trojanobelix

   on May 31, 2026

   Collaborator

   More actions

   Please try PR #220
8. trojanobelix

   assigned

   henri62

   on May 31, 2026
9. trojanobelix

   linked a pull request that will close this issuePrevent the mapping of objects with a data length of 0 bytes #220on May 31, 2026
10. trojanobelix

    added

    📭 needs: author feedbackMore info/confirmation awaited from OP; issues typically get closed after 30 days of inactivityMore info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity

    on May 31, 2026
11. trojanobelix commented on Jun 12, 2026

    

    trojanobelix

    on Jun 12, 2026

    Collaborator

    More actions

    

    Using the version provided at PR #220, I was able to open the xdd file available at #211 (comment).

    If the problem persists, please let me know how I can reproduce it.
12. henri62 commented on Jun 12, 2026

    

    henri62

    on Jun 12, 2026

    Author

    More actions

    I found the issue what was the original problem here:

    Access PDO : tr => This was not specified in my original bug report (I added this later, see start topic).

    The setting was the default "no" So the message "not mappable" is actually correct.

    What I also saw in that case that the application crashed on that, which actually ofcourse should not, but I'm not able to reproduce that problem (with the same version) any more.

    So to my opinion you may close this issue "Not a bug".
13. trojanobelix commented on Jun 12, 2026

    

    trojanobelix

    on Jun 12, 2026

    Collaborator

    More actions

    According to the OP, it's not a bug, so I'm closing this issue.
14. trojanobelix

    closed this as completedon Jun 12, 2026