Skip to content

Fixing #317 Invalid Eigenvalues#318

Merged
skfegan merged 1 commit intomainfrom
317-bug-invalid-eigenvalues
Apr 22, 2026
Merged

Fixing #317 Invalid Eigenvalues#318
skfegan merged 1 commit intomainfrom
317-bug-invalid-eigenvalues

Conversation

@skfegan
Copy link
Copy Markdown
Member

@skfegan skfegan commented Apr 22, 2026

Summary

Resolving Issue #317 by correcting the looping over frames.

Changes

Fixing level_dag.py

  • looping over trajectory frames in _run_frame_stage

Tests

  • update regression baselines

Impact

  • By looping over frames (not just frame index) in level_dag.py, the code is now collecting data from all the relevant frames not just the first one, so the sampling is correct.
  • This will reduce the number of invalid (zero, negative, or imaginary) eigenvalues and improve the vibrational entropy results.

@skfegan skfegan linked an issue Apr 22, 2026 that may be closed by this pull request
@skfegan skfegan requested review from ioanaapapa and jimboid April 22, 2026 09:43
@ioanaapapa
Copy link
Copy Markdown
Collaborator

It looks good to me and the results match what I was getting before.
dna_example_output.txt

Copy link
Copy Markdown
Collaborator

@ioanaapapa ioanaapapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me and the results match what I was getting before.

Copy link
Copy Markdown
Member

@jimboid jimboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An important bug fix. This looks like the origin was the quirky behaviour of how frames from MDA are dealt with in some types of iterables. We've had a valuable report from @ioanaapapa that the numbers are now indeed functioning correctly as per previous behaviour. I'm wholly satisfied that this PR fixes the issue reported with invalid eigen values.

@skfegan skfegan merged commit 5687d4e into main Apr 22, 2026
44 of 45 checks passed
@skfegan skfegan deleted the 317-bug-invalid-eigenvalues branch April 22, 2026 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid eigenvalues

3 participants