feat(timetable): add time-based timeline view - #8
Open
yudong-0222 wants to merge 3 commits into
Open
Conversation
Author
|
另外,我想請問在「自定義課程」新增節次為「1 ~ E」這種「數字 ~ 英文」或「英文 ~ 數字」是合法的操作嗎? |
Member
在我們的設計下,起訖時間合理就是一個合法的操作 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
說明
經過 #7 的建議與 Review 後,我重新以「功能」提出這個 PR,再麻煩進行 Review,謝謝!
我將原本以固定節次矩陣呈現的課表,改為依實際時間比例顯示的 Timeline。
此 PR 僅針對「課表顯示」功能,「時間查詢功能」與其他 RWD UI 會再另外拆 PR 出來。
修改內容
classStorage/rowspanize()結果建立 Timeline sessionsReuse / Implementation Notes
本次在實作上優先 reuse 原始專案的既有方法:
classStorage作為課表資料來源rowspanize()產生的連續區段資訊CoursegetterscourseDelete()show_comment()因此,未另外新增非必要的課程時間解析、range parser、overlap projection 或新的 course data model。
Testing
npm run build)