This repository was archived by the owner on Sep 19, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
[1주차] 유현우 미션 제출합니다. #3
Open
puba5
wants to merge
18
commits into
CEOS-Developers:master
Choose a base branch
from
puba5:test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
be6d4aa
Zeit을 통해 배포 성공
puba5 b38b6c8
README 수정, 경로 1 문제점,
puba5 1a0ed6c
배경과 BOX들 예시 페이지에서 CSS 맞춤
puba5 b46ffab
컴포넌트 반복을 통해 카드들 생성 및 CSS 양식 맞춤
puba5 7828088
CSS 양식 맞추기, 현재 page optimize 안되서 임시 저장 커밋
puba5 46bd280
Div 문제로 CSS 양식 안 맞추어지던 문제 해결
puba5 7aeec90
Add few <div> for make required design
puba5 c87cff8
Finished Mission And Add PR in Readme
puba5 ab2c384
추가 미션 부분을 알려주는 주석 추가
puba5 d63dbe8
profile 변수 이동한 후, 그에 맞추어 코드 수정
puba5 d080c2f
Readme PR 추가
puba5 a20db81
자기 PR 수정- 필수,선택 결과 화면 사진 크기 다른점
puba5 5af0753
코드 리팩토링
puba5 09590f0
mapToComponent함수 삭제 및 props 형태 변경
puba5 431c7a9
JS 구조 분해 할당으로 변수 이름 간략화
puba5 4febe17
각각의 컴포넌트를 다른 파일로 분리
puba5 4707662
컴포넌트 다시 하나로 통합
puba5 7107362
Rename "ProfileDescImg" to "Profile" and remove box-pack
puba5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,3 +28,5 @@ yarn-error.log* | |
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| .now | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,99 @@ | ||
| import React from 'react'; | ||
| import React from "react"; | ||
|
|
||
| import ProfileCard from '../components/profile-card'; | ||
| import styled from 'styled-components'; | ||
| import ProfileCard from "../src/components/profile-card"; | ||
| import styled from "styled-components"; | ||
|
|
||
| export default function Home() { | ||
| return ( | ||
| <Wrapper> | ||
| 나는 홈이야 | ||
| <ProfileCard /> | ||
| <Title>CEOS 프론트엔드 운영진</Title> | ||
| <ProfileCardsWrapper> | ||
| {profiles | ||
| .filter((profile) => profile.role !== "부회장") | ||
| .sort((a, b) => { | ||
| return a.age - b.age; | ||
| }) | ||
| .map((profile) => ( | ||
| <ProfileCard key={profile.id} {...profile} /> | ||
| ))} | ||
| </ProfileCardsWrapper> | ||
| ; | ||
| </Wrapper> | ||
| ); | ||
| } | ||
|
|
||
| const profiles = [ | ||
| { | ||
| id: 1, | ||
| name: "박효진", | ||
| age: 23, | ||
| role: "개발 파트장", | ||
| univ: "이화여자", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-5106-6785", | ||
| email: "gywls517@gmail.com", | ||
| githubLink: "https://github.com/gywlsp", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_982cbc3d638e49889d8ba64b3c70a6e3~mv2.jpeg/v1/crop/x_199,y_0,w_543,h_560/fill/w_350,h_347,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8E%E1%85%AC%E1%84%92%E1%85%AD%E1%84%8C%E1%85%B5%E1%86%AB.webp", | ||
| }, | ||
| { | ||
| id: 2, | ||
| name: "양병훈", | ||
| age: 25, | ||
| univ: "서강", | ||
| role: "운영 팀원", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-8200-1760", | ||
| email: "ybh1760@gmail.com", | ||
| githubLink: "https://github.com/ybh1760", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_3de533d9d5ee4bbaa5fe0c360e8f6a23~mv2.jpeg/v1/crop/x_0,y_456,w_3024,h_3119/fill/w_351,h_347,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8B%E1%85%A3%E1%86%BC%E1%84%87%E1%85%A7%E1%86%BC%E1%84%92%E1%85%AE%E1%86%AB.webp", | ||
| }, | ||
| { | ||
| id: 3, | ||
| name: "이수완", | ||
| age: 22, | ||
| univ: "이화여자", | ||
| role: "홍보 파트장", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-5503-7994", | ||
| email: "2swan965@gmail.com", | ||
| githubLink: "https://github.com/lee-soowan65", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/982853_a188a89325cb4a20b6a487f7e3de5d14~mv2.jpg/v1/crop/x_13,y_1126,w_2998,h_2829/fill/w_351,h_335,al_c,q_80,usm_0.66_1.00_0.01/4A2633DE-3322-4CDC-8F8C-35288D83C43B-500.webp", | ||
| }, | ||
| { | ||
| id: 4, | ||
| name: "최수민", | ||
| age: 26, | ||
| univ: "서강", | ||
| role: "부회장", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-4413-1261", | ||
| email: "react@kakao.com", | ||
| githubLink: "https://github.com/greatSumini", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_43446e9ac65e4f129083516175259a2b~mv2.jpeg/v1/crop/x_0,y_910,w_3024,h_3122/fill/w_347,h_351,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8E%E1%85%AC%E1%84%89%E1%85%AE%E1%84%86%E1%85%B5%E1%86%AB.webp", | ||
| }, | ||
| ]; | ||
|
|
||
| const Wrapper = styled.div` | ||
| background-color: blue; | ||
| height: 100vh; | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 100vh; | ||
| background-color: rgb(230, 255, 255); | ||
| padding: 5rem 10rem; | ||
| `; | ||
|
|
||
| const ProfileCardsWrapper = styled.div` | ||
| display: flex; | ||
| flex-direction: row; | ||
| -webkit-box-pack: justify; | ||
|
greatSumini marked this conversation as resolved.
|
||
| justify-content: space-between; | ||
| flex-wrap: wrap; | ||
|
greatSumini marked this conversation as resolved.
|
||
| `; | ||
|
|
||
| const Title = styled.div` | ||
|
greatSumini marked this conversation as resolved.
|
||
| font-size: 2.8rem; | ||
| margin-bottom: 2rem; | ||
| `; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,66 +1,102 @@ | ||
| import React from "react"; | ||
| import styled from "styled-components"; | ||
|
|
||
| export default function ProfileCard() { | ||
| const profiles = [ | ||
| { | ||
| id: 1, | ||
| name: "박효진", | ||
| age: 23, | ||
| role: "개발 파트장", | ||
| univ: "이화여자", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-5106-6785", | ||
| email: "gywls517@gmail.com", | ||
| githubLink: "https://github.com/gywlsp", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_982cbc3d638e49889d8ba64b3c70a6e3~mv2.jpeg/v1/crop/x_199,y_0,w_543,h_560/fill/w_350,h_347,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8E%E1%85%AC%E1%84%92%E1%85%AD%E1%84%8C%E1%85%B5%E1%86%AB.webp" | ||
| }, | ||
| { | ||
| id: 2, | ||
| name: "양병훈", | ||
| age: 25, | ||
| univ: "서강", | ||
| role: "운영 팀원", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-8200-1760", | ||
| email: "ybh1760@gmail.com", | ||
| githubLink: "https://github.com/ybh1760", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_3de533d9d5ee4bbaa5fe0c360e8f6a23~mv2.jpeg/v1/crop/x_0,y_456,w_3024,h_3119/fill/w_351,h_347,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8B%E1%85%A3%E1%86%BC%E1%84%87%E1%85%A7%E1%86%BC%E1%84%92%E1%85%AE%E1%86%AB.webp" | ||
| }, | ||
| { | ||
| id: 3, | ||
| name: "이수완", | ||
| age: 22, | ||
| univ: "이화여자", | ||
| role: "홍보 파트장", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-5503-7994", | ||
| email: "2swan965@gmail.com", | ||
| githubLink: "https://github.com/lee-soowan65", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/982853_a188a89325cb4a20b6a487f7e3de5d14~mv2.jpg/v1/crop/x_13,y_1126,w_2998,h_2829/fill/w_351,h_335,al_c,q_80,usm_0.66_1.00_0.01/4A2633DE-3322-4CDC-8F8C-35288D83C43B-500.webp" | ||
| }, | ||
| { | ||
| id: 4, | ||
| name: "최수민", | ||
| age: 26, | ||
| univ: "서강", | ||
| role: "부회장", | ||
| major: "컴퓨터공학", | ||
| phoneNum: "010-4413-1261", | ||
| email: "react@kakao.com", | ||
| githubLink: "https://github.com/greatSumini", | ||
| imageUrl: | ||
| "https://static.wixstatic.com/media/69e8c2_43446e9ac65e4f129083516175259a2b~mv2.jpeg/v1/crop/x_0,y_910,w_3024,h_3122/fill/w_347,h_351,al_c,q_80,usm_0.66_1.00_0.01/%E1%84%8E%E1%85%AC%E1%84%89%E1%85%AE%E1%84%86%E1%85%B5%E1%86%AB.webp" | ||
| } | ||
| ]; | ||
|
|
||
| return <Wrapper>안녕 나는 프로필 카드</Wrapper>; | ||
| export default function ProfileCard(props) { | ||
|
greatSumini marked this conversation as resolved.
|
||
| const { | ||
| id, | ||
| name, | ||
| age, | ||
| role, | ||
| univ, | ||
| major, | ||
| phoneNum, | ||
| email, | ||
| githubLink, | ||
| imageUrl, | ||
| } = props; | ||
| return ( | ||
| <CardWrapper> | ||
| <Profile> | ||
| <DescWrapper> | ||
| <div> | ||
| <Name> | ||
| {name}({age}) | ||
| </Name> | ||
| <Part>{role}</Part> | ||
| <Univ> | ||
| {univ}대학교 {major}과 | ||
| </Univ> | ||
| </div> | ||
| <div> | ||
| <PhoneNum>{phoneNum}</PhoneNum> | ||
| <Email>{email}</Email> | ||
| <GithubLink href={githubLink}>{githubLink}</GithubLink> | ||
| </div> | ||
| </DescWrapper> | ||
| <ProfileImage src={imageUrl} /> | ||
| </Profile> | ||
| <ClubName>신촌 연합 IT 창업 동아리 CEOS</ClubName> | ||
| </CardWrapper> | ||
| ); | ||
| } | ||
|
|
||
| const Wrapper = styled.div` | ||
| background-color: red; | ||
| font-size: 18px; | ||
| const CardWrapper = styled.div` | ||
| width: 45%; | ||
| background-color: rgb(255, 255, 255); | ||
| margin-bottom: 2rem; | ||
| padding: 1.5rem; | ||
| border: 1px solid rgb(204, 204, 204); | ||
| border-radius: 1.5rem; | ||
| `; | ||
|
|
||
| const Profile = styled.div` | ||
| display: flex; | ||
| flex-direction: row; | ||
| justify-content: space-between; | ||
| margin-bottom: 1.5rem; | ||
| `; | ||
|
|
||
| const ClubName = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| -webkit-box-align: center; | ||
|
greatSumini marked this conversation as resolved.
|
||
| align-items: center; | ||
| font-size: 1.6rem; | ||
| `; | ||
|
|
||
| const ProfileImage = styled.img` | ||
| width: 40%; | ||
| height: 40%; | ||
| `; | ||
|
|
||
| const DescWrapper = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| -webkit-box-pack: justify; | ||
| justify-content: space-between; | ||
| width: 50%; | ||
| `; | ||
|
|
||
| const Name = styled.div` | ||
| font-size: 2rem; | ||
| font-weight: bold; | ||
| margin-bottom: 1rem; | ||
| `; | ||
| const Univ = styled.div` | ||
| font-size: 1.4rem; | ||
| `; | ||
| const Part = styled.div` | ||
| font-size: 1.4rem; | ||
| font-weight: bold; | ||
| `; | ||
| const PhoneNum = styled.div` | ||
| font-size: 1.4rem; | ||
| color: rgb(0, 0, 153); | ||
| `; | ||
| const Email = styled.div` | ||
| font-size: 1.4rem; | ||
| color: rgb(0, 0, 153); | ||
| `; | ||
| const GithubLink = styled.a` | ||
| font-size: 1.4rem; | ||
|
greatSumini marked this conversation as resolved.
|
||
| `; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.