-
Notifications
You must be signed in to change notification settings - Fork 1
[CHORE] ui 수정 및 원문보기 연결 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
32e4414
feat: 회원가입 이용약관 모달 추가
5f47595
feat: 원문보기 연결(확정 이후 수정 예정)
3dee902
fix: 신규성 분석 페이지 수정하기 기능 관련 ui 수정
01cfab8
feat: 재탐색하기, 탐색 중단하기, 선행기술 탐색 경우 나눠서 필드 채워지게 수정
9b78ea9
Merge branch 'feat/analysis-api' of https://github.com/CEOS-IPX/IPX-F…
0b5f6fb
fix: 코드래빗 리뷰 반영
GirimNam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| "use client"; | ||
|
|
||
| import CancelIcon from "@/components/icons/icon-cancel.svg"; | ||
| import { Radio } from "@/components/ui/Radio"; | ||
| import type { TermsContent } from "@/constants/auth/terms"; | ||
|
|
||
| type TermsModalProps = { | ||
| content: TermsContent; | ||
| agreementLabel: string; | ||
| checked: boolean; | ||
| onToggle: () => void; | ||
| onClose: () => void; | ||
| }; | ||
|
|
||
| export function TermsModal({ | ||
| content, | ||
| agreementLabel, | ||
| checked, | ||
| onToggle, | ||
| onClose, | ||
| }: TermsModalProps) { | ||
| return ( | ||
| <div | ||
| className="fixed inset-0 z-50 flex items-center justify-center bg-scrim-2" | ||
| onClick={onClose} | ||
| > | ||
| <div | ||
| className="flex h-112.5 w-138.5 flex-col gap-6 rounded-lg bg-bg-surface p-8 shadow-[0px_1px_6px_0px_rgba(144,155,165,0.36)]" | ||
| onClick={(e) => e.stopPropagation()} | ||
| > | ||
| <div className="flex items-center justify-between"> | ||
| <h2 className="text-body-emphasis-17 text-title-primary">{content.title}</h2> | ||
| <button | ||
| type="button" | ||
| onClick={onClose} | ||
| aria-label="닫기" | ||
| className="flex cursor-pointer items-center justify-center" | ||
| > | ||
| <CancelIcon className="h-6 w-6" aria-hidden /> | ||
| </button> | ||
| </div> | ||
|
|
||
| <div className="flex flex-1 flex-col gap-6 overflow-y-auto pr-1 scrollbar-hide"> | ||
| {content.sections.map((section) => ( | ||
| <div key={section.heading} className="flex flex-col gap-2"> | ||
| <h3 className="text-body-emphasis-17 text-title-secondary">{section.heading}</h3> | ||
| {section.paragraphs?.map((paragraph) => ( | ||
| <p key={paragraph} className="text-body-15 text-body-secondary"> | ||
| {paragraph} | ||
| </p> | ||
| ))} | ||
| {section.bullets && ( | ||
| <ul className="flex flex-col gap-1 pl-4"> | ||
| {section.bullets.map((bullet) => ( | ||
| <li key={bullet} className="list-disc text-body-15 text-body-secondary"> | ||
| {bullet} | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| )} | ||
| {section.numbered && ( | ||
| <ol className="flex flex-col gap-1 pl-4"> | ||
| {section.numbered.map((item) => ( | ||
| <li key={item} className="list-decimal text-body-15 text-body-secondary"> | ||
| {item} | ||
| </li> | ||
| ))} | ||
| </ol> | ||
| )} | ||
| </div> | ||
| ))} | ||
| </div> | ||
|
|
||
| <hr className="h-px w-full border-0 bg-outline-sub" /> | ||
|
|
||
| <label className="flex cursor-pointer items-center gap-2"> | ||
| <Radio checked={checked} readOnly onClick={onToggle} /> | ||
| <span className="flex items-center gap-1"> | ||
| <span className="text-label-15 text-primary-default">[필수]</span> | ||
| <span className="text-label-15 text-title-secondary">{agreementLabel}</span> | ||
| </span> | ||
| </label> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 2659
🌐 Web query:
Next.js App Router routing pages layout segments docs💡 Result:
The Next.js App Router uses a file-system based routing architecture where folders and specific file conventions define the application's structure and behavior [1][2][3]. Route Segments and Folders Each folder within the app directory represents a route segment that maps to a URL segment [2][3]. By nesting folders, you create nested routes (e.g., app/blog/[slug]/page.tsx maps to /blog/:slug) [1][4]. Special File Conventions Next.js uses reserved file names to define specific UI and functionality for a segment [2][3]: - page.tsx: The UI unique to a route; makes a segment publicly accessible [2][4][5]. - layout.tsx: Shared UI that wraps child segments [2][6]. Layouts persist state and do not re-render upon navigation [1][2][4]. - loading.tsx: Defines loading UI (Suspense boundary) [4][7]. - error.tsx: An error boundary to catch runtime errors [4][7][5]. - not-found.tsx: UI displayed when a route is not found [4][7]. - template.tsx: Similar to a layout but re-mounts (re-renders) on navigation [3][7][5]. - route.ts: Defines server-side API endpoints [2][3]. Dynamic and Advanced Routing - Dynamic Segments: Created by wrapping a folder name in square brackets (e.g., [slug]) to generate routes from data [1][2]. Catch-all segments use [...slug], and optional catch-all segments use [[...slug]] [2][4][5]. - Route Groups: Folders wrapped in parentheses (e.g., (marketing)) allow you to organize routes without affecting the URL path [2][4][5]. - Private Folders: Folders prefixed with an underscore (_) are excluded from the router, allowing for colocation of internal logic, tests, or components [7][5]. Rendering Hierarchy Special files in a segment are rendered in a fixed hierarchy: layout -> template -> error -> loading -> not-found -> page [5]. Layouts are nested by default, meaning a parent layout wraps the child layout and page via the children prop [1][6]. The Root Layout (app/layout.tsx) is required and must contain the basic html and body tags [2][6][5].
Citations:
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 12872
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 446
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 296
인증 폼의 가로폭 제한을 화면 너비에 맞춰주세요.
Next.js App Router의layout은 자식 라우트 전체에 적용되므로, auth 라우트 공통w-125는 현재 화면 폭보다 좁은 작은 디스플레이에서 컨텐츠가 넘쳐도 좌우 스크롤(나침)이 나오지 않도록overflow-x-auto로 두지 않는 한 가로로 잘릴 수 있습니다.ProfileStep의 기존 방식처럼min-w-0 flex-1 self-stretch max-w-125로 바꿔 고정 폭은 상한만 유지하고 화면에 맞게 수렴하게 하세요.제안
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 21789
🏁 Script executed:
Repository: CEOS-IPX/IPX-FE
Length of output: 13366
🌐 Web query:
React flexbox overflow auto items-center scroll does not show overhanging content documentation💡 Result:
When using Flexbox with
align-items: centerorjustify-content: centeron a scrollable container, content that overflows is often clipped and becomes inaccessible because the browser attempts to "center" the entire overflowing content block relative to the container [1][2]. If the content is larger than the container, the centering calculation pushes the start of the content outside the viewable, scrollable area [3][2]. To fix this while maintaining centered alignment when content fits, use the following strategies: 1. Use Auto Margins (Recommended): Instead ofjustify-content: centeroralign-items: centeron the container, applymargin: autoto the flex items (or the inner container) [3][2]. Unlike alignment properties,margin: autowill only center content if there is extra space. If the content overflows, the margins collapse to zero, allowing the content to align to the start and remain fully accessible [3][4][2]. 2. The Safe Alignment Keyword: Modern CSS supports thesafekeyword for alignment properties (e.g.,justify-content: safe centeroralign-items: safe center) [2]. This tells the browser that if an item overflows its container, it should align as ifflex-startwere used, preventing the content from being pushed out of the scrollable area [2]. Note that browser support forsafeshould be verified for your specific target environments. 3. Nested Containers: Use an outer container for centering and an inner container for the overflow [5]. - Outer container:display: flex; justify-content: center;(oralign-items: center). - Inner container:display: flex; overflow: auto;(orscroll). This separates the alignment logic from the scrolling logic, ensuring that the inner container maintains the ability to scroll its contents without being affected by the outer centering [5]. When setting up these containers, ensure the parent has defined height/width constraints (e.g.,max-heightorheight), asoverflow: autorequires a bounded container to trigger the scrollbar [6][7].Citations:
중간 래퍼를 두어 스크롤과 중앙 정렬을 분리하세요.
현재
flex-1 items-center justify-center overflow-y-auto에min-h-215가 꽉 차면, React의 flexbox 스크롤-중첩 문제와 마찬가지로 콘텐츠 상단이 중앙 기준 스크롤 시작 위치 아래로 내려가서 약관 동의 같은 첫 필드가 보이지 않습니다. React App Router CSS 기반으로 작은 콘텐츠는 여전히 중앙 정렬되도록 외곽은flex-col overflow-y-auto, 내부 컨테이너는my-auto를 사용해 보세요.제안
📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Path instructions