constrain python package versions - #113
Open
JordanLaserGit wants to merge 1 commit into
Open
Conversation
JordanLaserGit
added
enhancement
pratikshac15
approved these changes
Aug 21, 2026
pratikshac15
left a comment
pratikshac15
left a comment
Collaborator
There was a problem hiding this comment.
Just curious, was nwmurl>=1.0.8 chosen because there is a specific fix or functionality in this version that forcingprocessor now requires?
Collaborator
Author
|
Anywhere I could, I set to latest version for all packages. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds minimum version constraints (and one targeted upper bound) to the project’s Python dependencies so builds are less likely to break due to inherited package changes in fresh environments, addressing issue #24.
Changes:
- Added minimum version floors for all runtime dependencies.
- Added an upper bound for
gcsfsto avoid a problematic release. - Added a minimum version floor for the
developextra (pytest).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
setup.cfg |
Adds >= version floors (and one < upper bound) to install_requires and pins pytest for the develop extra. |
pyproject.toml |
Mirrors dependency version floors in PEP 621 [project] dependencies and pins pytest in optional develop dependencies; documents the gcsfs upper bound rationale inline. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
29
to
+34
| install_requires = | ||
| boto3 | ||
| cftime | ||
| dask | ||
| exactextract | ||
| gcsfs | ||
| geopandas | ||
| imageio | ||
| matplotlib | ||
| netCDF4 | ||
| h5netcdf | ||
| h5py | ||
| nwmurl==1.0.1 | ||
| pandas | ||
| psutil | ||
| pyarrow | ||
| pyogrio | ||
| requests | ||
| s3fs | ||
| scipy | ||
| xarray | ||
| boto3>=1.43.56 | ||
| cftime>=1.6.5 | ||
| dask>=2026.7.1 | ||
| exactextract>=0.3.0 | ||
| gcsfs>=2026.7.0,<2026.8.0 |
Comment on lines
+14
to
+16
| "exactextract>=0.3.0", | ||
| "gcsfs>=2026.7.0,<2026.8.0", # 2026.8.0 deadlocks worker processes on GCS reads | ||
| "geopandas>=1.1.4", |
quinnylee
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds minimum version floors for all dependencies to better track forcingprocessor dependencies. This decreases the likelihood that pytests are broken by package version updates that are inherited in new build environments.
Closes #24
Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other