Add units used by the work-in-progress CSP dictionaries#14
Draft
vaitkus wants to merge 1 commit into
Draft
Conversation
jamesrhester
approved these changes
Jun 10, 2026
vaitkus
force-pushed
the
add-units-from-structure-prediction-dictionaries
branch
from
4b16315 to
cdf6c75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds units that are used in the work-in-progress version of the CSP dictionaries (see https://github.com/COMCIFS/Structure_Prediction_Dictionary).
The branch is not ready to be merged, however, any comments or suggestions are welcome as these could be useful as feedback for the CSP dictionary developers.
In the meantime, I plan on using this branch as is in the GitHub dictionary action checks of the CSP dictionaries.
Please note, that this initial version provides my interpretation of the units and thus may differ from the intention of the original authors. As such, it would be great if @nicholasfrancia could comments is any of the descriptions should be changed.