Skip to content

Add dictionary URIs for deprecated data names#483

Draft
vaitkus wants to merge 2 commits into
COMCIFS:mainfrom
vaitkus:add-alias-uri
Draft

Add dictionary URIs for deprecated data names#483
vaitkus wants to merge 2 commits into
COMCIFS:mainfrom
vaitkus:add-alias-uri

Conversation

@vaitkus

@vaitkus vaitkus commented Feb 20, 2024

Copy link
Copy Markdown
Collaborator

This PR adds dictionary URI for the deprecated aliases.

The URIs were chosen to refer to the versions of the dictionary in which those specific aliases were deprecated. These URIs might need to be changed if the definition of the _alias.dictionary_uri attribute get reworded (see issue #481).

@vaitkus

vaitkus commented May 6, 2026

Copy link
Copy Markdown
Collaborator Author

I have created this PR quite a while ago and have been keeping it in sync ever since. At some point I designated this PR as draft even though it had an approval from @jamesrhester. I mainly refrained from merging it since I was unsure if such information is not too lengthy and distracting to be included in the printed version of the dictionary (e.g. ITC Volume G).

@jamesrhester , @nautolycus do you have any opinion on this?

@jamesrhester

Copy link
Copy Markdown
Contributor

The automatic typesetting of the dictionaries can simply ignore this extra attribute when deciding what to display. @nautolycus , OK to merge into the release candidate or would you prefer it goes in main (i.e. next version released sometime next year)?

@nautolycus

Copy link
Copy Markdown
Collaborator

@nautolycus , OK to merge into the release candidate or would you prefer it goes in main (i.e. next version released sometime next year)?

I do apologise for missing this direct inquiry. I am happy either way. As @jamesrhester indicates, it will be ignored anyway in typesetting the volume.

@jamesrhester

Copy link
Copy Markdown
Contributor

I would prefer this goes into main just to keep changes to the release candidate as minimal as possible at this stage.

@vaitkus

vaitkus commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator Author

Sure, no need to rush this. The branch can be merged after the release of the current release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add _alias.dictionary_uri to aliases where possible

3 participants