Fix reciprocal axis terminology#592
Merged
jamesrhester merged 3 commits intoMay 5, 2026
Merged
Conversation
Collaborator
|
@jamesrhester Maybe this and the corresponding PR in the template dictionary should also be merged before the next release of coreCIF given that they are already prepared? I will approve the PR, but it would be good if someone more experienced could confirm that the change is scientifically sound. |
vaitkus
approved these changes
May 4, 2026
Contributor
Author
|
I have reviewed Nespolo, J. Appl. Cryst. (2024) p 1733. The change in terminology is to reflect the fact that the unit cell of the reciprocal lattice will not be described by the reciprocals of the direct space unit cell if the direct space unit cell is non-primitive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is simply that content of #557 relating to
cif_core.dic. A separate PR in the other repository will cover changes totempl_attr.cif. Once I've prepared that I will close #557.