Change enumeration value from 'rot_anode' to 'rot-anode'#618
Merged
vaitkus merged 1 commit intoJun 24, 2026
Merged
Conversation
jamesrhester
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically a breaking change so please review before merging.
Enumeration values for
_diffrn_source.devicewere introduced only after migration from DDL1 to DDLm. The underscore in the enumeration value looks a bit strange, especially when the full text explanation ('Rotating-anode') contains a a dash. Technically, the underscored values has already been published as part of the initial DDLm coreCIF dictionary release, however, in practice it does not seem to have been used at all (1 instance in the latest COD r306607, 2026-06-21; valueelectron_gun).