Skip to content

Apply minor rewording#624

Merged
jamesrhester merged 2 commits into
COMCIFS:rc-3.3.0from
vaitkus:apply-minor-rewording
Jun 30, 2026
Merged

Apply minor rewording#624
jamesrhester merged 2 commits into
COMCIFS:rc-3.3.0from
vaitkus:apply-minor-rewording

Conversation

@vaitkus

@vaitkus vaitkus commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Sorry for the late PR, I only now rediscovered these minor issues in my notes. If it is too late to include them in this release, I will reissue the PR on the main branch.

Main issues in definition descriptions addressed by this PR:

  • In the latest version of the dictionary, the diffraction radiation wavelength is described by the DIFFRN_RADIATION_WAVELENGTH category while the DIFFRN_RADIATION category describes the general properties of the radiation beam. Furthermore, items in the DIFFRN_RADIATION_WAVELENGTH category are not exclusively used for non-polychromatic beams, thus I have removed this specific word from the DIFFRN_RADIATION description (it remains in the DIFFRN_RADIATION_WAVELENGTH description).
  • The term 'diffrn_radiation_wavelength' referred neither to a category nor a specific data item thus I have changed it to _diffrn_radiation_wavelength.value.

vaitkus added 2 commits June 30, 2026 16:51
The diffraction radiation wavelength is fully described by the
DIFFRN_RADIATION_WAVELENGTH category while the DIFFRN_RADIATION
category describes the general properties of the radiation beam.
@jamesrhester jamesrhester merged commit f102375 into COMCIFS:rc-3.3.0 Jun 30, 2026
3 checks passed
@vaitkus vaitkus deleted the apply-minor-rewording branch July 1, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants