add GEOM_*.model_id as linked key#52
Open
rowlesmr wants to merge 5 commits into
Open
Conversation
To copy what is done in multi_block_core
rowlesmr
changed the title
jamesrhester
approved these changes
Jun 25, 2026
jamesrhester
left a comment
jamesrhester
left a comment
Contributor
There was a problem hiding this comment.
I believe the individual *.model_id link data names do not need defining as they were already defined in cif_multi.dic.
Clarified documentation regarding the omission of model_id for various geometry categories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will close #48
As given in
cif_multi, theGEOM_*categories have_model.idas a linked (composite) key dataname.Now, too, does
cif_ms.The definitions of
_geom_*.model_idare delegated tocif_multi, but the setting it as a key name is done here, ascif_multican't override definitions incif_ms.