Add _atom_site_Fourier_wave_vector.structure_id#61
Open
rowlesmr wants to merge 81 commits into
Open
Conversation
Deprecate atom sites rot fourier
Atom sites structure key
Add structure keys
Add refln.structure
Geom model id key
Updated the definition update date and added new keys for cell wave vectors.
Added definitions for cell wave vector structure and vectors ID.
Updated dates and added linked key for Fourier wave vector.
Id for cell wave vector(s)
Contributor
Author
|
undid an erroneous merge @jamesrhester back on track |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #54, #56, and #60
Add
_atom_site_Fourier_wave_vector.structure_idas linked composite key to_structure.id. Makes sense from its description, and also, as dataitems in this category are linked to those incell_wave_vector, we also need_structure.idto ensure we're referring to the same thing.