alter category keys: pd_calib_xcoord and pd_qpa_external_std#290
Open
rowlesmr wants to merge 13 commits into
Open
alter category keys: pd_calib_xcoord and pd_qpa_external_std#290rowlesmr wants to merge 13 commits into
pd_calib_xcoord and pd_qpa_external_std#290rowlesmr wants to merge 13 commits into
Conversation
Removed _pd_calib_xcoord.xcoord_overall_id (kept as linked non-key) Added _pd_calib_xcoord.detector_id -> otherwise don't know which detector is being calibrated
It was a circuitous lookup. Use instr_id associated with the unknown diffractogram to look up the (non-key) instr_id of the diffractogram in the qpa_ext_std table to get the k_factor. K factors are associated with instruments. If anything changes in the instrument, particularly anything to do with flux, a new id is required, and so a new K_factor can be gotten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pd_calib_xcoord- originally keyed on.idand.xcoord_overall_id(linked to_pd_calib_xcoord_overall.id). There was no way to link each point of the calibration to the detector it was calibrating..xcoord_overall_idwas demoted to linked non-key data item..detector_idpromoted to part of composite key. Updated the examples.pd_qpa_external_std- originally keyed on.diffractogram_id. This was only used to get to the associated.instr_idvalue, so I decided to cut out the middleman and key it directly on.instr_id. This has the side-effect of requiring a new_pd_instr.idif a recalibration is required, but this was always implicitly there..diffractogram_iddemoted to linked, non-key data name..instr_idadded as category key. Updated the example to link the mass absorption coefficient of the specimen to the diffractogram though apd_char,pd_prep,pd_specchain.Also misc changes putting the category key names in alphabetical order for all categories.