fix: escape composed executable paths on Windows - #153
Open
lorenzotumini wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#148 fixed paths containing whitespace by shell-escaping each substituted variable. On Windows, the default compiled-language commands now expand
$dir/$fileNameWithoutExtinto two separately quoted fragments:"C:\path\to\dir"/"program"When Neovim passes this through
cmd.exe, the directory is interpreted as the command and the compiled executable is not launched.Fix
Expand
$dir/$fileNameWithoutExtand its backslash variant as one complete path before processing individual variables, then shell-escape that complete path.This preserves the existing placeholder API and user configurations while retaining the whitespace fix from #148. Replacement callbacks ensure that
%characters in paths remain literal.Testing
cmd.exe