Skip to content

List API has changed to GET Method #66

Description

@Error042

In the BaseClient.php the list method uses LIST as the HTTP Method.

In the Hashicorp Vault documentation all the list endpoints use a standard GET HTTP method. So I get an Error when sending the call.

It just needs to change from this:

/**
 * @param string $path
 *
 * @return Response
 * @throws InvalidArgumentException
 * @throws ClientExceptionInterface
 */
public function list(string $path = ''): Response
{
    return $this->responseBuilder->build($this->send('LIST', $path));
}

To this:

/**
 * @param string $path
 *
 * @return Response
 * @throws InvalidArgumentException
 * @throws ClientExceptionInterface
 */
public function list(string $path = ''): Response
{
    return $this->responseBuilder->build($this->send('GET', $path));
}

Should be not a big deal. :)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions