Skip to content

99.6% hull.py test coverage - #2096

Open
kimstik wants to merge 2 commits into
CadQuery:masterfrom
kimstik:hull_fix2
Open

kimstik wants to merge 2 commits into
CadQuery:masterfrom
kimstik:hull_fix2

Conversation

@kimstik

@kimstik kimstik commented Sep 14, 2026

Copy link
Copy Markdown

Added tests for the bits of hull.py nothing was hitting.
Two of them found real bugs along the way - a lone circle didn't work,
and one input hung forever - so there's a small fix in "find_hull" too.

kimstik added 2 commits September 14, 2026 12:28
They were computed as if every arc were centred at the origin, so
select_lowest_arc compared meaningless points for partial arcs.
@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.80%. Comparing base (cb26a27) to head (268a99a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
+ Coverage   95.76%   95.80%   +0.04%     
==========================================
  Files          30       30              
  Lines        9584     9589       +5     
  Branches     1437     1439       +2     
==========================================
+ Hits         9178     9187       +9     
+ Misses        250      247       -3     
+ Partials      156      155       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant