Fix TPU evaluation inference-mode crash - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch.inference_mode()withtorch.no_grad()inevaluate_probeevaluate_bleuReproduction
On a TPU v5e (
v5litepod-4) with torch 2.6.0 / torch_xla 2.6.0, the quick smoke reached its first evaluation forward pass and failed with:RuntimeError: Cannot set version_counter for inference tensorThe stack terminates in
evaluate_probe -> model -> q_projunder the@torch.inference_mode()decorator.Rationale
PyTorch inference mode has known incompatibilities with tensor subclasses. XLA tensors are tensor subclasses.
torch.no_grad()disables autograd without converting intermediate tensors to inference tensors, which is appropriate for this metric path.