Explain Stellar network selection and deposit preparation

[greatest0fallt1me]

Summary

docs/deposit-transaction-builder.md and docs/network-configuration.md describe TransactionBuilderService, but omit that DepositController rejects networks different from config.stellar.network, that vaults must exist first, and that fees and timeouts come from specific env variables.

Why this matters

Frontend integrators receive INVALID_NETWORK or vault-not-found errors without understanding why.

Scope

Document the end-to-end deposit flow: vault registration, POST /api/vault/deposit/prepare body, network rules, returned XDR fields, simulation diagnostics redaction and signing responsibilities.

Relevant code in CalloraOrg/Callora-Backend:

• docs/deposit-transaction-builder.md
• docs/network-configuration.md
• src/controllers/depositController.ts

Priority

Low

Acceptance criteria

• The request and response schemas match DepositPrepareRequest/Response
• Network mismatch behaviour is described
• Env variables for fee and timeout are listed
• An example XDR signing snippet is included

Validation

Verify examples against npm test -- src/controllers/depositController.test.ts.

Non-goals

• Typo-only, formatting-only, or cosmetic changes.
• Unrelated refactors, dependency upgrades, or broad rewrites.
• Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.

---

Generated by Claude Code

[shobhamerabacha-star]

Hi there,

I am interested in working on this issue.
Plan:

1. Add comprehensive test coverage for Add focused test coverage for src/routes/invoices/health.ts verifying edge cases and failure scenarios.
2. Verify all test cases pass locally and in the GitHub Actions CI workflow.

Looking forward to contributing—please assign whenever convenient!

[Obaara293]

@Obaara293 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi maintainer, I've reviewed the issue and I've recognized the solution, kindly assign this to me to get the best result.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Obaara293 to this issue.

[drips-wave]

Congratulations, @Obaara293! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on September 30, 2026.

🧑‍💻 @Obaara293: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊