Emit structured logs instead of console calls

[greatest0fallt1me]

Summary

src/services/billing.ts, src/services/revenueSettlementService.ts, src/services/rateLimiter.ts, src/routes/billing.ts, src/controllers/depositController.ts and src/app.ts still use console.error/console.warn, bypassing the pino logger and its redaction rules.

Why this matters

Console output lacks requestId and redaction, so secrets could leak and log aggregation cannot correlate errors.

Scope

Replace console.* with logger calls carrying context objects, and enable the no-console ESLint rule for src/ (excluding scripts/).

Relevant code in CalloraOrg/Callora-Backend:

• src/services/billing.ts
• src/services/revenueSettlementService.ts
• src/services/rateLimiter.ts
• eslint.config.js

Priority

Low

Acceptance criteria

• No console.* calls remain in the listed source files
• ESLint no-console is enabled for src
• Log entries include requestId where available
• Redaction tests in src/logger.test.ts still pass

Validation

Run npm run lint and npm test -- src/logger.test.ts.

Non-goals

• Typo-only, formatting-only, or cosmetic changes.
• Unrelated refactors, dependency upgrades, or broad rewrites.
• Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.

---

Generated by Claude Code

[shobhamerabacha-star]

Hey maintainers,

I can tackle Add focused test coverage for src/routes/limits.ts. Proposed implementation roadmap:

• Analysis: Inspect current behavior and edge cases in CalloraOrg/Callora-Backend
• Core Implementation: Add comprehensive test coverage for Add focused test coverage for src/routes/limits.ts verifying edge cases and failure scenarios.
• Quality Assurance: Verify all test cases pass locally and in the GitHub Actions CI workflow.

Excited to work on this—please assign to me and I will submit a clean PR shortly!

[Simbabi]

@Simbabi has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

Hi maintainer, I'd like to work on this. I'll swap the console.error/console.warn calls in the five listed files for the existing pino logger, passing structured context objects (error, relevant IDs) instead of interpolated strings, and pull requestId from AsyncLocalStorage the way docs/request-id-propagation.md describes so it attaches automatically rather than needing to be threaded through each call site manually. I'll enable no-console in eslint.config.js scoped to src/ only, confirm src/logger.test.ts's redaction tests still pass afterward, and check scripts/ isn't accidentally covered by the new rule. Ready to get started.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Simbabi to this issue.

[OLAMIGHTY010]

@OLAMIGHTY010 has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

I would like to work on this project

ℹ️ Repo Maintainers: To accept this application, review their application or assign @OLAMIGHTY010 to this issue.

[Daveeee-tech]

@Daveeee-tech has applied to work on this issue as part of the Stellar Wave Program's 9th wave.

hi maintainer please assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Daveeee-tech to this issue.