fix: move bcrypt key checks off the event loop - #1398
Open
blesswill88 wants to merge 4 commits into
Open
blesswill88 wants to merge 4 commits into
blesswill88 wants to merge 4 commits into
Conversation
|
@blesswill88 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR moves API key hashing and verification off the Node event loop by replacing the synchronous bcrypt calls in
apiKeyRepositorywith the async bcrypt APIs, adding a short-lived LRU cache for recent successful verifications, and using a sha256 exact-match lookup for high-entropy keys. It also updates the gateway auth middleware to await the now-async verification path and adds tests covering the async behavior and cache eviction.Related Issue
Changes
🔐 API Key Repository
src/repositories/apiKeyRepository.tsverifyis nowasyncand usesbcrypt.compareinstead ofbcrypt.compareSync.createusesbcrypt.hashinstead ofbcrypt.hashSync.🛡️ Gateway Auth Middleware
src/middleware/gatewayApiKeyAuth.tsawaitthe asyncverifycall so the event loop is not blocked during key checks.⚙️ Config
src/config/index.ts🧪 Tests
src/repositories/apiKeyRepository.test.tsverify, successful verification, rejected keys, and cache eviction on revocation.src/middleware/gatewayApiKeyAuth.test.tsVerification Results
verifyis async and does not usecompareSyncverifyisasyncand usesbcrypt.compareapiKeyRepository.test.tsandgatewayApiKeyAuth.test.tspassSecurity and Failure Modes
Compatibility
verifybecoming async; all call sites were updated toawaitit.Closes #1274