Conversation
|
@Obaara293 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR documents the end-to-end deposit preparation flow for frontend integrators: vault registration prerequisites, the
POST /api/vault/deposit/preparerequest/response contract, network selection rules enforced byDepositController, fee/timeout environment variables, simulation diagnostics redaction, and signing responsibilities. It is a documentation-only change — no runtime behaviour, validation, or safeguards are modified.Related Issue
Changes
📄 Deposit transaction builder docs
docs/deposit-transaction-builder.mdPOST /api/vault/deposit/prepare.DepositPrepareRequest(vault id, amount, asset, destination, and related fields).DepositPrepareResponse, including the returned XDR fields and their meaning.config.stellar.networkare rejected byDepositControllerwithINVALID_NETWORK.🌐 Network configuration docs
docs/network-configuration.mdconfig.stellar.networkis resolved and how it governs deposit preparation.Verification Results
Examples in the docs were checked against
src/controllers/depositController.tsand theDepositPrepareRequest/DepositPrepareResponseschemas so the documented fields, error codes (INVALID_NETWORK, vault-not-found), and env variable names match the implementation. No test files were added or modified by this PR.INVALID_NETWORKrejection when network ≠config.stellar.networkSecurity and Failure Modes
INVALID_NETWORK, vault-not-found) and their causes so they are not mistaken for transient errors.Compatibility
Documentation-only. No API, schema, or configuration changes, so existing integrators are unaffected.
Closes #1347